refactor(pxe)!: remove legacy oracle compat, rename V2 oracles#23425
Merged
Conversation
nchamo
commented
May 20, 2026
| describe('utilityResolveMessageContexts', () => { | ||
| const requestSlot = Fr.random(); | ||
| const responseSlot = Fr.random(); | ||
| describe('getMessageContextsByTxHash', () => { |
Contributor
Author
There was a problem hiding this comment.
I just repurposed the v1 tests for v2, since we didn't have any
benesjan
approved these changes
May 20, 2026
benesjan
left a comment
benesjan
left a comment
Contributor
There was a problem hiding this comment.
LGTM
BTW there is a whole project with some more issues related to this
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE refactor(pxe)!: remove legacy oracle compat, rename V2 oracles (AztecProtocol#23425) refactor(pxe)!: drop V1 oracle remnants, simplify nullifier witness (AztecProtocol#23428) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LEGACY_ORACLE_VERSION = 12shim and 18 legacy oracle name aliases inlegacy_oracle_mappings.ts— the v5 protocol contract redeployment means all contracts now run on the current oracle version.getPendingTaggedLogs,validateAndStoreEnqueuedNotesAndEvents,getLogsByTag,getMessageContextsByTxHash.*V2oracle methods and handlers (e.g.aztec_utl_getPendingTaggedLogs_v2→aztec_utl_getPendingTaggedLogs) across the Noir, TS PXE, and TXE layers.ORACLE_VERSION_MAJOR23 → 24 and recomputesORACLE_INTERFACE_HASH.Fixes F-416