Skip to content

fix: export $CONTRACT var in end to end test#2344

Closed
critesjosh wants to merge 3 commits into
masterfrom
jc/export-contract-guide-test
Closed

fix: export $CONTRACT var in end to end test#2344
critesjosh wants to merge 3 commits into
masterfrom
jc/export-contract-guide-test

Conversation

@critesjosh

Copy link
Copy Markdown
Contributor

This PR saves the deployed contract address to CONTRACT, so that it can be referenced as $CONTRACT in the remainder of the test, and these command can be referenced in the docs.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

Comment thread yarn-project/end-to-end/src/guides/up_quick_start.sh
@critesjosh critesjosh requested a review from benesjan September 16, 2023 00:24
# docs:end:deploy

aztec-cli check-deploy --contract-address 0x03b030d48607ba8a0562f0f1f82be26c3f091e45e10f74c2d8cebb80d526a69f
# docs:start:declare-contract

@Maddiaa0 Maddiaa0 Sep 16, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag is created but i dont see where it is used

@critesjosh critesjosh Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be part of this PR: #2322

EDIT: I will move this changes to that PR since it's where it's relevant.

@critesjosh

Copy link
Copy Markdown
Contributor Author

Moving these changes to this PR (#2322)

@critesjosh critesjosh closed this Sep 18, 2023
auto-merge was automatically disabled September 18, 2023 12:58

Pull request was closed

@critesjosh critesjosh deleted the jc/export-contract-guide-test branch September 18, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants