fix: stale detector#23504
Merged
Merged
Conversation
The detector still checked for the pre-AZIP-8 shape (raw `*_m` points), so it silently returned false for every modern contract ABI and the TS codegen fell back to the inlined struct literal instead of the typed `PublicKeys` parameter. Rename the three field checks to the `_hash` variants and update the one call site that was matching the old fallback shape to pass the `PublicKeys` instance directly (the encoder routes class instances through `encodeToNoir`).
jeanmon
approved these changes
May 22, 2026
Merged
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE fix: stale detector (AztecProtocol#23504) test(avm): add schnorr verify to bulk test (AztecProtocol#23467) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the detector code as part of the azip-8 pr so we don't have to use
toNoirStruct