test(e2e): scope sentinel proposer-node assertion to selected slot#23594
Closed
AztecBot wants to merge 1 commit into
Closed
test(e2e): scope sentinel proposer-node assertion to selected slot#23594AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiple_validators_sentinel.parallel.test.tsto the selected first-node proposer slot.Analysis
Failed run: http://ci.aztec-labs.com/eb23494dc3ab7289
The failing test was
e2e_p2p_multiple_validators_sentinel > collects attestations for validators in proposer node when block is not published. The assertion checked every online validator history entry in(initialSlot, slotForSentinel]and expected noattestation-missed,blocks-missed, orcheckpoint-missedstatuses.In the failed run, the selected sentinel slot was 11 and the first-node proposer had the expected
checkpoint-validstatus at slot 11. The failure came from an earlier slot 10 history entry,blocks-missed, for that same validator. Since node 2 had already been stopped, an intermediate first-node proposer can legitimately fail quorum before the test reaches the selected slot. That makes the wide online-validator assertion stricter than the behavior this test is trying to prove.The recent e2e fixes by
spalladinopoint in the same direction: keep strict assertions tied to the selected slot/configuration after pipelining and warm-up effects are accounted for. In particular, #23573 already added the warm-up checkpoint wait here; this PR applies the remaining scoping fix for the second sentinel test.Testing
git diff --checkyarn prettier --check end-to-end/src/e2e_p2p/multiple_validators_sentinel.parallel.test.tscould not run locally because this checkout has no Yarnnode_modulesstate file (Couldn't find the node_modules state file).Created by claudebox · group:
slackbot