Skip to content

test(e2e): scope sentinel proposer-node assertion to selected slot#23594

Closed
AztecBot wants to merge 1 commit into
merge-train/spartanfrom
cb/61c0992db5ed
Closed

test(e2e): scope sentinel proposer-node assertion to selected slot#23594
AztecBot wants to merge 1 commit into
merge-train/spartanfrom
cb/61c0992db5ed

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Summary

  • Scope the online-validator sentinel assertion in multiple_validators_sentinel.parallel.test.ts to the selected first-node proposer slot.
  • Keep the offline-validator assertion over the full post-stop window, since that is still the intended missed-activity coverage.
  • Add an inline comment explaining why intermediate first-node proposer slots are not part of this assertion.

Analysis

Failed run: http://ci.aztec-labs.com/eb23494dc3ab7289

The failing test was e2e_p2p_multiple_validators_sentinel > collects attestations for validators in proposer node when block is not published. The assertion checked every online validator history entry in (initialSlot, slotForSentinel] and expected no attestation-missed, blocks-missed, or checkpoint-missed statuses.

In the failed run, the selected sentinel slot was 11 and the first-node proposer had the expected checkpoint-valid status at slot 11. The failure came from an earlier slot 10 history entry, blocks-missed, for that same validator. Since node 2 had already been stopped, an intermediate first-node proposer can legitimately fail quorum before the test reaches the selected slot. That makes the wide online-validator assertion stricter than the behavior this test is trying to prove.

The recent e2e fixes by spalladino point in the same direction: keep strict assertions tied to the selected slot/configuration after pipelining and warm-up effects are accounted for. In particular, #23573 already added the warm-up checkpoint wait here; this PR applies the remaining scoping fix for the second sentinel test.

Testing

  • git diff --check
  • yarn prettier --check end-to-end/src/e2e_p2p/multiple_validators_sentinel.parallel.test.ts could not run locally because this checkout has no Yarn node_modules state file (Couldn't find the node_modules state file).

Created by claudebox · group: slackbot

@AztecBot AztecBot added the claudebox Owned by claudebox. it can push to this PR. label May 27, 2026
@AztecBot

AztecBot commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant