Skip to content

chore(foundation): return pre-allocated ZERO_BUFFER in field toBuffer #23597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fcarreiro wants to merge 1 commit into from
Closed

chore(foundation): return pre-allocated ZERO_BUFFER in field toBuffer #23597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion yarn-project/foundation/src/curves/bn254/field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ type DerivedField<T extends BaseField> = {
*/
abstract class BaseField {
static SIZE_IN_BYTES = 32;
private static readonly ZERO_BUFFER = Buffer.alloc(BaseField.SIZE_IN_BYTES);
private readonly asBigInt: bigint;

/**
Expand Down Expand Up @@ -67,7 +68,10 @@ abstract class BaseField {
* Converts the bigint to a Buffer.
*/
toBuffer(): Buffer {
return toBufferBE(this.asBigInt, 32);
if (this.asBigInt === 0n) {
return BaseField.ZERO_BUFFER;
}
return toBufferBE(this.asBigInt, BaseField.SIZE_IN_BYTES);
}

toString(): `0x${string}` {
Expand Down
Loading