Skip to content

test(e2e): narrow down sentinel check in multiple_validators_sentinel #23604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilWindle merged 1 commit into from
May 27, 2026
Merged

test(e2e): narrow down sentinel check in multiple_validators_sentinel #23604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions yarn-project/end-to-end/src/e2e_p2p/multiple_validators_sentinel.parallel.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,11 +214,14 @@ describe('e2e_p2p_multiple_validators_sentinel', () => {
const stats = await sentinel.getValidatorsStats();
t.logger.info(`Collected validator stats at slot ${t.monitor.l2SlotNumber}`, { stats });

// Check that all of the first node validators have attestations recorded
const historyForSlot = (validator: (typeof firstNodeValidators)[number]) =>
stats.stats[validator.toString().toLowerCase()]?.history.filter(h => h.slot === slotForSentinel) ?? [];

// Check that all of the first node validators have attestations recorded for the selected proposer slot.
for (const validator of firstNodeValidators) {
const validatorStats = stats.stats[validator.toString().toLowerCase()];
const history = validatorStats?.history.filter(h => h.slot > initialSlot && h.slot <= slotForSentinel) ?? [];
const history = historyForSlot(validator);
t.logger.info(`Asserting stats for online validator ${validator}`, { history });
expect(history).not.toBeEmpty();
expect(
history.filter(
h => h.status === 'attestation-missed' || h.status === 'blocks-missed' || h.status === 'checkpoint-missed',
Expand All @@ -229,14 +232,13 @@ describe('e2e_p2p_multiple_validators_sentinel', () => {
// At least one of the first node validators must have been seen as proposer
const firstNodeBlockProposedHistory = firstNodeValidators
.flatMap(v => stats.stats[v.toString().toLowerCase()].history)
.filter(h => h.slot > initialSlot && h.slot <= slotForSentinel)
.filter(h => h.slot === slotForSentinel)
.filter(h => h.status === 'checkpoint-valid' || h.status === 'checkpoint-mined');
expect(firstNodeBlockProposedHistory).not.toBeEmpty();

// And all of the proposers for the offline node must be seen as missed attestation or proposal
// And all of the validators for the offline node must be seen as missed attestation or proposal.
for (const validator of offlineValidators) {
const validatorStats = stats.stats[validator.toString().toLowerCase()];
const history = validatorStats.history?.filter(h => h.slot > initialSlot && h.slot <= slotForSentinel) ?? [];
const history = historyForSlot(validator);
t.logger.info(`Asserting stats for offline validator ${validator}`, { history });
expect(
history.filter(
Expand Down
Loading