fix: replace deprecated BoundedVec::from_parts_unchecked in aztec-nr#23689
Closed
AztecBot wants to merge 1 commit into
Closed
fix: replace deprecated BoundedVec::from_parts_unchecked in aztec-nr#23689AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added a commit
that referenced
this pull request
Jun 1, 2026
Bumps the noir submodule to nightly-2026-06-01 (originally #23487) and bundles the two follow-up changes needed for CI to pass on this bump: - Replace deprecated BoundedVec::from_parts_unchecked with from_parts in aztec-nr (note_getter.nr, subbvec.nr). The bumped noir stdlib deprecates from_parts_unchecked, and aztec-nr's warnings check runs nargo check --deny-warnings, so the two call sites aborted the build. from_parts and from_parts_unchecked have identical signatures/bodies in the current stdlib, so this is a no-op-at-runtime migration. (originally #23689) - Regenerate the @aztec/noir-noir_js file: entry in yarn-project/yarn.lock, whose content hash went stale (294c27 -> 341fef) when the noir packages changed, breaking yarn install --immutable.
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
merge-train/spartanfails at the[aztec-nr]step (log, parent 1780055514267304). The failure is unrelated to the world-state change (#23677) that the train picked up — it is an integration break: the noir submodule merged onto this train deprecatedBoundedVec::from_parts_unchecked, and aztec-nr's warnings check runsnargo check --deny-warnings, so the two remaining call sites abort the build:Fix
Swap both call sites to
BoundedVec::from_parts. In the current noir stdlibfrom_partsandfrom_parts_uncheckedhave identical signatures and identical bodies (from_partsno longer does an extra zeroing loop), so this is a semantically equivalent, no-op-at-runtime migration — it just drops the deprecated symbol. The now-stale comments justifying the_uncheckedvariant were updated accordingly.Only
aztec-nris checked with--deny-warnings; the otherfrom_parts_uncheckedusages live innoir-protocol-circuitstest modules whose check runs without--deny-warnings, so they are not part of this failure and are left untouched.Verification
Built
nargofrom this train's pinned noir submodule and ran the exact failing commands fromaztec-nr/bootstrap.sh:nargo check --deny-warnings→ exit 0 (previously aborted)nargo doc --check→ exit 0Created by claudebox · group:
slackbot