fix: cap cloned n_tps fees within sponsored FPC balance#23770
Merged
Conversation
Stop setting maxFeesPerGas to 1000× priority on cloned txs so mempool validation no longer rejects high-value benchmark sends for insufficient fee payer balance; fail the run when no high-value txs are sent or included.
PhilWindle
approved these changes
Jun 1, 2026
spalladino
approved these changes
Jun 1, 2026
| clonedTxData.data.constants.txContext.gasSettings = GasSettings.from({ | ||
| gasLimits: gasSettings.gasLimits, | ||
| teardownGasLimits: gasSettings.teardownGasLimits, | ||
| maxFeesPerGas: priorityFee, |
Contributor
There was a problem hiding this comment.
Heads up this works only because we're computing the priority fee as 10x the base fee in L388, which is a bit odd. Also, if the network is loaded, base fees will keep growing, so this may eventually fail. Maybe we can leave a 10x instead of 1000x just for safety?
Collaborator
There was a problem hiding this comment.
Can we just query the node for the current base fee at the point of cloning/submission and then differentiate high/low fee txs via the priority fee?
danielntmd
pushed a commit
to danielntmd/aztec-packages
that referenced
this pull request
Jun 4, 2026
BEGIN_COMMIT_OVERRIDE chore: deploy next-net and reuse contracts (AztecProtocol#23761) chore: turn on autoscaling (AztecProtocol#23706) chore: rename staging-public to staging (AztecProtocol#23767) chore(p2p): use sync hash for tx validation hashing (AztecProtocol#23768) test(e2e): wait warmup slots in slashing tests (AztecProtocol#23719) feat(api)!: make getTxReceipt the single tx-lookup API (AztecProtocol#23660) fix: cap cloned n_tps fees within sponsored FPC balance (AztecProtocol#23770) fix: protect HA validator Postgres from cluster scale-down (AztecProtocol#23772) refactor: remove non-pipelining sequencer code path (AztecProtocol#23665) feat(archiver): add getL2ToL1MembershipWitness node RPC (AztecProtocol#23646) fix(p2p)!: revamp BLOCK_TXS validations (AztecProtocol#23778) chore: name the bots (AztecProtocol#23795) fix(e2e): ensure BBSync init (AztecProtocol#23793) fix(p2p)!: fix BLOCK_TXS response under proposer equivocation (AztecProtocol#23786) fix: reconnect L1 port-forward after epoch-boundary sleep in n_tps_prove (AztecProtocol#23800) chore: add empty vscode settings for yarn-project (AztecProtocol#23808) fix(sequencer): only warn about missing proposed checkpoint once overdue (AztecProtocol#23807) fix: refresh n_tps fee quotes during sustained benchmark (AztecProtocol#23797) fix(sequencer): enforce build-frame deadlines and align attestation/publish windows (AztecProtocol#23776) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
maxFeesPerGasto 1000× the priority bid inn_tps.test.tscloneTx; cap max and priority fees at the bid so mempool fee-payer validation stays within the sponsored FPC genesis balance.benchmarkruns).