fix: quiet malformed chonk proof rejection#23822
Open
AztecBot wants to merge 9 commits into
Open
Conversation
Random-linear-combine (via a fresh challenge gamma) the G_0 binding check and the main IPA relation in IPA::batch_reduce_verify so the batch performs a single SRS MSM / IPA commitment instead of two.
AztecBot
force-pushed
the
cb/07fa8374405a
branch
2 times, most recently
from
d109495 to
eb50077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #23484 (
cb/07fa8374405a).Summary
{ valid: false }directly when native Chonk verification reportsverified=false, instead of throwing into the warning path.CI-full follow-up
The failed
e2e_prover/fullleaf passed all 4 Jest tests, then hung afterJest did not exit one second after the test run has completeduntil the CI wrapper timed out. The node and batch verifier services logged clean stop, so the likely leak was the RPC verifier's logger-attached native socket backend handles.Verification
git diff --checkyarn --cwd yarn-project/bb-prover buildcould not run in this checkout: missingyarn-project/node_modules/.bin/tsgo.bbapi_tests --gtest_filter=BBApiInputValidation.ChonkVerifyFromFieldsWrongVkSizeReturnsInvalid:BBApiInputValidation.ChonkBatchVerifyWrongVkSizeReturnsInvalid:BBApiInputValidation.ChonkVerifyWrongVkSizeReturnsInvalidcould not run becausebarretenberg/cpp/build/bin/bbapi_testsis not built in this checkout.Created by claudebox · group:
slackbot