feat(aztec-nr): include delivery mode in handshake discovery#23873
Merged
nchamo merged 7 commits intoJun 5, 2026
Merged
Conversation
nchamo
commented
Jun 4, 2026
| /// enumerate on its own (e.g. handshake-derived ones). `mode` is a delivery mode constant from | ||
| /// [`crate::messages::message_delivery`] (`ONCHAIN_UNCONSTRAINED` or `ONCHAIN_CONSTRAINED`). | ||
| #[derive(Serialize)] | ||
| #[allow(dead_code)] |
Contributor
Author
There was a problem hiding this comment.
Since we removed the test, we now need to add this. Until we actually use it later
…elivery-tagged-log-retrieval-in-default
vezenovm
approved these changes
Jun 4, 2026
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
nchamo
deleted the
nchamo/f-588-constrained-delivery-tagged-log-retrieval-in-default
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[eph_pk.x, mode]instead of just[eph_pk.x], so the recipient knows the delivery mode (constrained vs unconstrained) for each handshake.DiscoveredHandshake { eph_pk, mode }in the capsule array instead of bareEmbeddedCurvePoint, andget_handshakesreturns this enriched type.ProvidedSecret.modenow uses delivery mode constants directly (2/3) instead of a separate numbering (0/1), eliminating the need for a mapping layer.