fix(yarn-project): restore noir packages to beta.21 in yarn.lock#23888
Closed
AztecBot wants to merge 1 commit into
Closed
fix(yarn-project): restore noir packages to beta.21 in yarn.lock#23888AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
merge-train/spartan-v5is failing at theyarn-projectbuild step (log: http://ci.aztec-labs.com/1780602815190408). Theyarn install --immutablestep aborts with:Root cause
The head commit on the train, #23827 (feat!: proofless tx lookup in getTxByHash and getTxsByHash), accidentally bumped the
@aztec/noir-*package versions inyarn-project/yarn.lockfrom1.0.0-beta.21→1.0.0-beta.22(versions, resolution hashes, and checksums). That change is unrelated to the PR's actual content (all other touched files are.ts/docs).The noir packages on this branch are still
beta.21— confirmed at the source: the noir submodule (f1a4575) declares1.0.0-beta.21in.release-please-manifest.jsonand in every package'spackage.json(acvm_js,noir_js,noir_js_types, …). Soyarn install --immutableresolvesbeta.21from thefile:/portal:packages, findsbeta.22pinned in the lockfile, and refuses to proceed. The CI resolver's own output confirms it wanted to rewrite the lockfile back tobeta.21.Fix
Restore the noir entries in
yarn-project/yarn.locktobeta.21, matching the actual noir packages on the branch (identical to commit107b336~1, the train state before #23827 was squashed in). This is the only change; the diff is limited to the spurious noir version/hash/checksum lines.Verification
beta.21everywhere — the lockfile now matches ground truth, soyarn install --immutablewill compute zero changes.beta.21lockfile) passed CI../bootstrap.sh cicould not be run in this environment (missing Rust/cargo toolchain — not the CI build-image — and the host disk is at 94%). The fix is a deterministic lockfile alignment, verified against the noir package sources rather than a full rebuild.Created by claudebox · group:
slackbot