fix: realign yarn.lock noir versions on merge-train/spartan-v5#23890
Closed
AztecBot wants to merge 1 commit into
Closed
fix: realign yarn.lock noir versions on merge-train/spartan-v5#23890AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
merge-train/spartan-v5fails at theyarn install --immutablestep (log):yarn-project/yarn.lockpins the@aztec/noir-*packages (noir_js,acvm_js,noirc_abi,types,noir_codegen) at1.0.0-beta.22, but the noir submodule on this branch (noir/noir-repo @ f1a4575) declares1.0.0-beta.21. With--immutable, the mismatch is a hard failure.Root cause
feat!: proofless tx lookup in getTxByHash and getTxsByHash(#23827, commit107b3361) carried a stray lockfile change: its only edit toyarn.lockwas bumping those noir entries frombeta.21→beta.22(versions,file:resolution hashes, and checksum). The PR did not change the noir submodule pointer, so the lockfile no longer matches thebeta.21noir packages that CI actually builds.Fix
Restore
yarn-project/yarn.lockto its pre-#23827 state (the lockfile that was consistent withbeta.21noir and passing CI before this PR). This reverts only the 8 stray noir hunks — no other lockfile content changes.Verification
YN0028immutable mismatch) from the CI log and confirmed the lockfile is the sole cause.f1a4575,beta.21), so realigning the lockfile alone fully restores consistency../bootstrap.sh cicould not run in this environment (no docker → no local redis, no noir wasm build, no artifact cache), so the immutable install could not be exercised end-to-end here. The change is deterministic: the lockfile is byte-identical to the parent train tip's passing lockfile.Created by claudebox · group:
slackbot