Skip to content

fix: realign yarn.lock noir versions on merge-train/spartan-v5#23890

Closed
AztecBot wants to merge 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-yarn-lock
Closed

fix: realign yarn.lock noir versions on merge-train/spartan-v5#23890
AztecBot wants to merge 1 commit into
merge-train/spartan-v5from
cb/fix-spartan-v5-yarn-lock

Conversation

@AztecBot

@AztecBot AztecBot commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Problem

CI on merge-train/spartan-v5 fails at the yarn install --immutable step (log):

➤ YN0028: │ -  version: 1.0.0-beta.22
➤ YN0028: │ +  version: 1.0.0-beta.21
...
Cache download of node-modules-... failed → yarn install --immutable → failed
make: *** [Makefile:345: yarn-project] Error 1

yarn-project/yarn.lock pins the @aztec/noir-* packages (noir_js, acvm_js, noirc_abi, types, noir_codegen) at 1.0.0-beta.22, but the noir submodule on this branch (noir/noir-repo @ f1a4575) declares 1.0.0-beta.21. With --immutable, the mismatch is a hard failure.

Root cause

feat!: proofless tx lookup in getTxByHash and getTxsByHash (#23827, commit 107b3361) carried a stray lockfile change: its only edit to yarn.lock was bumping those noir entries from beta.21beta.22 (versions, file: resolution hashes, and checksum). The PR did not change the noir submodule pointer, so the lockfile no longer matches the beta.21 noir packages that CI actually builds.

Fix

Restore yarn-project/yarn.lock to its pre-#23827 state (the lockfile that was consistent with beta.21 noir and passing CI before this PR). This reverts only the 8 stray noir hunks — no other lockfile content changes.

Verification

  • Reproduced the exact failure class (YN0028 immutable mismatch) from the CI log and confirmed the lockfile is the sole cause.
  • Confirmed the noir submodule pointer is unchanged by feat!: proofless tx lookup in getTxByHash and getTxsByHash #23827 (f1a4575, beta.21), so realigning the lockfile alone fully restores consistency.
  • A full local ./bootstrap.sh ci could not run in this environment (no docker → no local redis, no noir wasm build, no artifact cache), so the immutable install could not be exercised end-to-end here. The change is deterministic: the lockfile is byte-identical to the parent train tip's passing lockfile.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Jun 4, 2026
@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​aztec/​noir-noir_js@​1.0.0-beta.22 ⏵ 1.0.0-beta.21100100100100100

View full report

@AztecBot

Copy link
Copy Markdown
Collaborator Author

Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed.

@AztecBot AztecBot closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant