fix(ci): restore yarn.lock to noir beta.21 on merge-train/spartan-v5#23891
Closed
AztecBot wants to merge 1 commit into
Closed
fix(ci): restore yarn.lock to noir beta.21 on merge-train/spartan-v5#23891AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
The 'revert two bad automerges' commit (9e53e1f) moved the noir submodule back to v1.0.0-beta.21, but the subsequently-merged proofless tx lookup PR (#23827) carried a stale yarn.lock pinning the @aztec/noir-* packages at npm:1.0.0-beta.22. This drift made 'yarn install --immutable' fail in the yarn-project CI step. Restore the six @aztec/noir-* entries (versions, resolution hash, and checksum) to the beta.21 values that match the noir submodule on this branch. This is exactly the lockfile yarn regenerates against the built beta.21 noir packages, so 'yarn install --immutable' now passes.
AztecBot
added
ci-draft
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
merge-train/spartan-v5is failing in the[yarn-project]step (log). Theyarn install --immutablesubstep aborts withYN0028(lockfile would be modified):Root cause
The noir submodule and
yarn.lockdrifted out of sync on the branch:9e53e1f805e("revert two bad automerges") moved thenoir/noir-reposubmodule back tof1a4575(v1.0.0-beta.21) and, at that commit,yarn.lockcorrectly referenced the@aztec/noir-*packages atbeta.21.107b3361844(feat!: proofless tx lookup in getTxByHash and getTxsByHash #23827, proofless tx lookup), carried a staleyarn.lockthat re-pinned the six@aztec/noir-*entries atnpm:1.0.0-beta.22(yarn.lock is a binary-detected file, so this regression was silent in the diff).Result: noir packages build at
beta.21but the lockfile demandsbeta.22, soyarn install --immutablewants to rewrite it → CI fails.Fix
Restore
yarn-project/yarn.lockto thebeta.21state from9e53e1f805e. The diff is exactly the six@aztec/noir-*entries (versions, thenoir_jsresolution hash893a3e→294c27, and its checksum) — nothing else. This is precisely the lockfile yarn regenerates against the builtbeta.21noir packages.Verification
beta.21noir JS packages (noir/bootstrap.sh build_packages, cache hit) and confirmednoir/packages/*declare1.0.0-beta.21.cd yarn-project && yarn install --immutablenow exits 0 — this is the exact substep that failed in the CI log — and leaves the lockfile unchanged.Full
./bootstrap.sh ci-full-no-test-cachecould not run to completion in the sandbox (no docker / remote build cache, so the native barretenberg C++ and cross-compile targets build from scratch and time out before reaching[yarn-project]). The CI failure was exclusively the immutable-install drift in[yarn-project], which is deterministically resolved here.