fix(ci): restore noir 1.0.0-beta.21 yarn.lock entries on spartan-v5#23892
Closed
AztecBot wants to merge 1 commit into
Closed
fix(ci): restore noir 1.0.0-beta.21 yarn.lock entries on spartan-v5#23892AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Collaborator
Author
|
Automatically closing this stale claudebox draft PR (no updates for 5+ days). Re-open if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
merge-train/spartan-v5failed in theyarn-projectbuild step (log 1780602818274491, commit107b3361844). Theyarn install --immutablestep aborted with YN0028 frozen_lockfile_exception:Root cause
PR #23827 ("proofless tx lookup") is unrelated to Noir, but its commit on this branch inadvertently bumped the Noir package entries in
yarn-project/yarn.lockfrom1.0.0-beta.21to1.0.0-beta.22(version,file:resolution hash294c27→893a3e, thenoir_jschecksum, and thenoir_codegen/noir_js/noirc_abidependency pins).The
noir/noir-reposubmodule pointer on this branch was not changed — it stays atf1a4575whose packages declare1.0.0-beta.21. So the committed lockfile (beta.22) no longer matched what the portal/file:resolution produces from the submodule (beta.21), and--immutablecorrectly refused. This is the exact drift the recently-added "fail loudly on yarn.lock drift" check (#23882) is meant to catch.The beta.22 entries are residue of a reverted Noir bump — commit
9e53e1f("revert two bad automerges") had already restored the submodule to the beta.21 pointerf1a4575with the matching beta.21 lockfile.Fix
Revert only the Noir lockfile entries back to
1.0.0-beta.21. The resultingyarn-project/yarn.lockis byte-identical to commit9e53e1f— the canonical consistent state that pairs submodulef1a4575with the beta.21 lockfile (file:checksumef758950…, resolution hash294c27). No other lockfile changes; the submodule pointer is untouched.Verification
With
noir/packagesmaterialized from the build cache (real beta.21 content), the previously-failing step now passes:Only
yarn-project/yarn.lockchanges;noir/noir-repois unmodified.Created by claudebox · group:
slackbot