refactor(pxe): replace Oracle class with Proxy-based buildACIRCallback#23915
Merged
Conversation
mverzilli
added a commit
that referenced
this pull request
Jun 8, 2026
Brings in TransientArray (#23576) and the Proxy-based buildACIRCallback oracle dispatch (#23915). Conflict resolutions: - oracle.ts: accepted upstream's deletion of the hand-written 711-line dispatch. FactStore oracles now dispatch through the registry-driven buildACIRCallback; their entries auto-merged into oracle_registry.ts. - utility_execution_oracle.ts: dropped the obsolete `Oracle` import, kept `FactOutput`. FactStore and transient handler methods auto-merged. - oracle_version.ts: recomputed ORACLE_INTERFACE_HASH for the merged 65-oracle registry (ae63cb…) and bumped minor 29.1 -> 29.2 (the merged interface is a strict superset of both branches' independent 29.1 additions). Mirrored the minor bump into the two Noir version files. Verified: TS build green, oracle hash confirmed by check_oracle_version, offchain + FactStore Noir suite 13/13 and oracle_version_is_checked 9/9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildACIRCallbackfunction (~100 lines) replaces the entire class by dispatching dynamically from registry keys.callHandlerexport andORACLE_NAMEStype.