test(ci): skip non-deterministic expand::test_avm_test_contract snapshot#23935
Merged
vezenovm merged 2 commits intoJun 8, 2026
Merged
Conversation
vezenovm
reviewed
Jun 8, 2026
vezenovm
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
merge-train/fairies-v5(#23881) keeps getting kicked out of the merge queue byexpand::test_avm_test_contractinnoir-projects/contract-snapshots:This is not a stale snapshot. The committed
.snapis correct, and the diffis ordering-only — the same generated interface functions (
call_fee_juice,nested_call_large_calldata,new_nullifier) shuffle position with identicalbodies/selectors.
Root cause:
nargo expandemits the macro-generated contract-interface functionsin hashmap-iteration order, which is not stable across nargo builds/runs.
Evidence:
nargo 1.0.0-beta.22, the suite passes40/40 with the committed ordering, including in the merged-with-
v5-nextcontext the merge queue tests.
same noir submodule pin as the passing tip, yet the queue runner generated the
opposite ordering and failed.
So the test fails intermittently in the merge queue purely on order-only diffs,
blocking the train.
What
Skip only
expand::test_avm_test_contractin the contract-snapshotstesttarget (
cargo test -- --skip ...). All other 60 snapshot tests still run. Thisis narrower than the
ci-skiplabel, which would disable the entire CI run.Revert condition
Temporary. Re-enable once
nargo expandproduces deterministic interface-functionordering (e.g. sort by name/selector) in noir. The skip carries a TODO pointing at noir-lang/noir#12933
Created by claudebox · group:
slackbot