Skip to content

test(ci): skip non-deterministic expand::test_avm_test_contract snapshot#23935

Merged
vezenovm merged 2 commits into
merge-train/fairies-v5from
cb/skip-flaky-avm-expand-snapshot
Jun 8, 2026
Merged

test(ci): skip non-deterministic expand::test_avm_test_contract snapshot#23935
vezenovm merged 2 commits into
merge-train/fairies-v5from
cb/skip-flaky-avm-expand-snapshot

Conversation

@AztecBot

@AztecBot AztecBot commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Why

merge-train/fairies-v5 (#23881) keeps getting kicked out of the merge queue by
expand::test_avm_test_contract in noir-projects/contract-snapshots:

This is not a stale snapshot. The committed .snap is correct, and the diff
is ordering-only — the same generated interface functions (call_fee_juice,
nested_call_large_calldata, new_nullifier) shuffle position with identical
bodies/selectors.

Root cause: nargo expand emits the macro-generated contract-interface functions
in hashmap-iteration order, which is not stable across nargo builds/runs.
Evidence:

  • On the branch tip with the pinned nargo 1.0.0-beta.22, the suite passes
    40/40 with the committed ordering, including in the merged-with-v5-next
    context the merge queue tests.
  • The failing merge-queue commit had the same committed snapshot blob and the
    same noir submodule pin
    as the passing tip, yet the queue runner generated the
    opposite ordering and failed.

So the test fails intermittently in the merge queue purely on order-only diffs,
blocking the train.

What

Skip only expand::test_avm_test_contract in the contract-snapshots test
target (cargo test -- --skip ...). All other 60 snapshot tests still run. This
is narrower than the ci-skip label, which would disable the entire CI run.

Revert condition

Temporary. Re-enable once nargo expand produces deterministic interface-function
ordering (e.g. sort by name/selector) in noir. The skip carries a TODO pointing at noir-lang/noir#12933


Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-squash claudebox Owned by claudebox. it can push to this PR. labels Jun 8, 2026
Comment thread noir-projects/contract-snapshots/bootstrap.sh Outdated
@vezenovm vezenovm marked this pull request as ready for review June 8, 2026 15:53
@vezenovm vezenovm enabled auto-merge (squash) June 8, 2026 15:54
@vezenovm vezenovm merged commit 5890d7b into merge-train/fairies-v5 Jun 8, 2026
16 checks passed
@vezenovm vezenovm deleted the cb/skip-flaky-avm-expand-snapshot branch June 8, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-squash claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants