chore: deploy staging from next scripts/helm#24013
Merged
Merged
Conversation
AztecBot
added
ci-draft
alexghr
approved these changes
Jun 11, 2026
alexghr
changed the title
next scripts/helmnext scripts/helm
AztecBot
force-pushed
the
cb/nightly-deploys-checkout-next
branch
from
5f462eb to
84a6ecf
Compare
## What Make all three nightly deployments run the deploy from the tip of `next` (latest scripts + helm) while keeping the correct image for each target network. ### Deploy ref → `next` - `deploy-staging-internal.yml`, `deploy-staging-public.yml`: pass `ref: next` to `deploy-network.yml` so the `spartan/` deploy scripts and helm charts come from `next`. - `deploy-next-net.yml` already passed `ref: next` (unchanged). ### `determine-tag` job (staging) - Checkout a single commit at the tip of `next` (`ref: next`, `fetch-depth: 1`) instead of `v5-next` with full history. - Tag resolution: if an explicit `tag` input is given, use it as-is. Otherwise construct `v5.0.0-nightly.<date>` and verify it actually exists with `git ls-remote --exit-code --tags origin`, failing the deploy early if the nightly tag is missing rather than proceeding to deploy a non-existent image. ## Why `deploy-network.yml` checks out `inputs.ref` to run the deploy scripts/helm; when unset it falls back to `github.ref` (default branch on `schedule`, dispatch branch on `workflow_dispatch`), making the scripts/helm implicit and branch-dependent. Pinning to `next` keeps staging on the latest infra while `semver`/`source_tag` continue to select the v5-line image (`v5.0.0-nightly.<date>`), which is the correct image for the staging networks. The `v5.0.0-nightly.<date>` tag is created on both the public and private repos (the nightly tagger tags `v5-next` on both), so the `git ls-remote origin` check resolves against whichever repo the workflow runs in.
AztecBot
force-pushed
the
cb/nightly-deploys-checkout-next
branch
from
84a6ecf to
5bb74e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Make all three nightly deployments run the deploy from the tip of
next(latest scripts + helm) while keeping the correct image for each target network.Deploy ref →
nextdeploy-staging-internal.yml,deploy-staging-public.yml: passref: nexttodeploy-network.ymlso thespartan/deploy scripts and helm charts come fromnext.deploy-next-net.ymlalready passedref: next(unchanged).determine-tagjob (staging)next(ref: next,fetch-depth: 1) instead ofv5-nextwith full history.taginput is given, use it as-is. Otherwise constructv5.0.0-nightly.<date>and verify it actually exists withgit ls-remote --exit-code --tags origin, failing the deploy early if the nightly tag is missing rather than proceeding to deploy a non-existent image.Why
deploy-network.ymlchecks outinputs.refto run the deploy scripts/helm; when unset it falls back togithub.ref(default branch onschedule, dispatch branch onworkflow_dispatch), making the scripts/helm implicit and branch-dependent. Pinning tonextkeeps staging on the latest infra whilesemver/source_tagcontinue to select the v5-line image (v5.0.0-nightly.<date>), which is the correct image for the staging networks.The
v5.0.0-nightly.<date>tag is created on both the public and private repos (the nightly tagger tagsv5-nexton both), so thegit ls-remote origincheck resolves against whichever repo the workflow runs in.