fix(ci): refresh grind launcher checkout to origin/next before launching#24039
Merged
Conversation
ludamad
approved these changes
Jun 11, 2026
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard
grindoption always fails to SSH into the build instance:The instance launches fine (spot/on-demand fulfilled, IP assigned) but SSH never connects, so grind cycles through every instance type and gives up.
Root cause
CI build boxes were migrated from SSH to SSM. In
ci3/bootstrap_ec2the default is nowCI_USE_SSH=0(SSM); onlyshell-newforces SSH, andgrind-testdoes not. So on currentnext, grind runs over SSM like the rest of CI.But the dashboard launches grind from a long-lived checkout at
REPO_PATH(the/grindhandler inrk.pyshells out tocd $REPO_PATH && ./ci.sh grind-test ...). That checkout had drifted to a pre-SSM commit, so grind alone still took the legacy SSH branch — launching into the retired SSH security group +build-instancekey pair, whose port-22 / key-injection preconditions were torn down during the SSM lockdown. The stale checkout also explains the old AMI (ami-09d27244b23be8891) in the logs vs. currentnext'sami-067627aa971a1dcbb.Nothing kept
REPO_PATHcurrent: theci3-dashboard-deploy.ymlworkflow only rebuilds therkappFlask container (and is path-filtered toci3/dashboard/**), so changes to theci3/launcher scripts never refreshed it.Fix
Refresh the launcher checkout to
origin/nextat grind launch time, before shelling out. This is self-healing and independent of deploys. It matches the existing design where the launcher always runs current-nextorchestration scripts while the grind target commit is checked out on the remote box — so this does not restrict which branch/commit you can grind. If the refresh fails (e.g. transient network), the error is surfaced in the run log instead of silently grinding on a stale tree.Testing
python3 -m py_compile ci3/dashboard/rk.pypasses. The behavior change is host-side (requires the dashboard'sREPO_PATHcheckout) and can't be exercised in unit CI; it will take effect on the next dashboard deploy. The immediate one-time unblock is still to refreshREPO_PATHonci.aztec-labs.comand restartrkapp.Created by claudebox · group:
slackbot