Skip to content

fix(docs): repair webapp tutorial build on spartan train#24057

Merged
PhilWindle merged 1 commit into
merge-train/spartanfrom
cb/fix-spartan-docs-webapp
Jun 12, 2026
Merged

fix(docs): repair webapp tutorial build on spartan train#24057
PhilWindle merged 1 commit into
merge-train/spartanfrom
cb/fix-spartan-docs-webapp

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Why

PR #23971 was removed from the next merge queue at 2026-06-12T15:23:40Z. The failing merge-group run was CI3 run 27424805463 on gh-readonly-queue/next/pr-23971-fa063393c7d16e1484957ca86d0b2d53a81d9d48 (66597f3f1e56113db60a31224946b3c130c32289).

The failed job was ci, specifically shard x9-full:

The docs webapp tutorial build failed with:

src/components/TwoPlayerLocal.tsx(67,20): error TS2339: Property 'connectTestAccount' does not exist on type 'NodeEmbeddedWallet'.
src/components/TwoPlayerLocal.tsx(68,30): error TS2339: Property 'getConnectedAccount' does not exist on type 'NodeEmbeddedWallet'.
[vite]: Rollup failed to resolve import "vite-plugin-node-polyfills/shims/buffer" from ".../yarn-project/stdlib/dest/aztec-address/index.js".

Fix

  • Make the tutorial EmbeddedWallet.initialize() method return the tutorial subclass type explicitly, preserving connectTestAccount() and getConnectedAccount() for callers.
  • Set Vite resolve.preserveSymlinks in the tutorial app and extension configs so linked @aztec/* packages resolve plugin-injected polyfill shims from the tutorial app install.

Verification

  • git diff --check
  • ./bootstrap.sh ci was attempted locally but this checkout has no root ci command and exits with Unknown command: ci.
  • docs/examples/bootstrap.sh was attempted for the focused failing area, but this container is missing built toolchain artifacts (noir/noir-repo/target/release/nargo, l1-contracts/solc-0.8.30), so it stops before the CI-reported webapp tutorial TypeScript/Vite failures.

Created by claudebox · group: slackbot

@AztecBot AztecBot added ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR. labels Jun 12, 2026
@PhilWindle PhilWindle marked this pull request as ready for review June 12, 2026 15:49
@PhilWindle PhilWindle requested a review from a team as a code owner June 12, 2026 15:49
@PhilWindle PhilWindle merged commit f5c4dda into merge-train/spartan Jun 12, 2026
44 of 52 checks passed
@PhilWindle PhilWindle deleted the cb/fix-spartan-docs-webapp branch June 12, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants