feat: throw compile error if read/write public state from private

[LHerskind]

Currently if accessing public state from private functions you will only get an error at runtime. This pr changes such that you will receive a compile-time error instead.

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

• If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
• I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
• Every change is related to the PR description.
• I have linked this pull request to relevant issues (if any exist).

[LHerskind]

Initially only allowed public to read. But need to disallow private instead. Reason being that unconstrained functions should be allowed to read from public storage even though it is not a public function.

[AztecBot]

Benchmark results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 6d855270 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,444	179,588	716,132
l1_rollup_calldata_gas	222,996	868,280	3,449,708
l1_rollup_execution_gas	842,083	3,595,388	22,205,077
l2_block_processing_time_in_ms	1,016 (-4%)	3,928 (-4%)	15,312 (-5%)
note_successful_decrypting_time_in_ms	324 (-2%)	1,009 (-3%)	3,687 (-5%)
note_trial_decrypting_time_in_ms	⚠️ 26.0 (-21%)	108 (+1%)	137 (-1%)
l2_block_building_time_in_ms	8,956 (-4%)	35,919 (-3%)	149,838 (-4%)
l2_block_rollup_simulation_time_in_ms	6,642 (-4%)	26,646 (-3%)	105,257 (-4%)
l2_block_public_tx_process_time_in_ms	2,271 (-2%)	9,149 (-2%)	43,793 (-4%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,421 (-3%)	31,571 (-2%)
note_history_successful_decrypting_time_in_ms	2,336 (-3%)	4,784 (-3%)
note_history_trial_decrypting_time_in_ms	122 (+1%)	146 (-1%)
node_database_size_in_bytes	1,650,157	1,196,023
pxe_database_size_in_bytes	27,188	54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	43.8 (-2%)	56,577	14,745
private-kernel-ordering	21.1 (-3%)	20,137	8,089
base-rollup	851 (-1%)	631,605	811
root-rollup	37.9 (-1%)	4,072	1,097
private-kernel-inner	35.8 (-6%)	72,288	14,745
public-kernel-private-input	47.1 (-2%)	37,359	14,745
public-kernel-non-first-iteration	28.0 (-4%)	37,401	14,745
merge-rollup	⚠️ 0.870 (-12%)	2,592	873