chore: remove redundant methods and use hash instead of compress in the interface#3038
Closed
kevaundray wants to merge 15 commits into
Closed
chore: remove redundant methods and use hash instead of compress in the interface#3038kevaundray wants to merge 15 commits into
hash instead of compress in the interface#3038kevaundray wants to merge 15 commits into
Conversation
…t hash_index=0 is common enough that we could keep it
Closed
Base automatically changed from
kw/pedersen-cleanup-rm-plookup-namespace
to
master
October 25, 2023 18:12
This was referenced Oct 25, 2023
kevaundray
added a commit
that referenced
this pull request
Oct 25, 2023
Extracting this from #3038 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
kevaundray
added a commit
that referenced
this pull request
Oct 25, 2023
Partly extracted from #3038 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Contributor
Author
|
This has been merged into master piecewise by the linked commits, the issues encountered were:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes quite a few methods from the interface:
Related to #3029
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.