Skip to content

chore: Add portal contract option to deploy subcommand of aztec-cli#3044

Closed
Maddiaa0 wants to merge 4 commits into
masterfrom
ax0/master
Closed

chore: Add portal contract option to deploy subcommand of aztec-cli#3044
Maddiaa0 wants to merge 4 commits into
masterfrom
ax0/master

Conversation

@Maddiaa0

@Maddiaa0 Maddiaa0 commented Oct 25, 2023

Copy link
Copy Markdown
Member

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

mirror of :
#3032

This PR adds a portal contract option to the 'deploy' subcommand' of aztec-cli.

@Maddiaa0 Maddiaa0 changed the title Ax0/master chore: Add portal contract option to deploy subcommand of aztec-cli Oct 25, 2023
@Maddiaa0 Maddiaa0 enabled auto-merge (squash) October 25, 2023 17:11
@Maddiaa0 Maddiaa0 requested a review from dan-aztec October 25, 2023 17:12
@Maddiaa0 Maddiaa0 closed this Oct 25, 2023
auto-merge was automatically disabled October 25, 2023 17:14

Pull request was closed

@AztecBot

Copy link
Copy Markdown
Collaborator

Benchmark results

Metrics with a significant change:

  • circuit_simulation_time_in_ms (base-rollup): 2,427 (+16%)
  • circuit_simulation_time_in_ms (merge-rollup): 1.12 (+34%)
  • node_history_sync_time_in_ms (5): 28,873 (+16%)
  • node_history_sync_time_in_ms (10): 56,671 (+17%)
  • note_history_successful_decrypting_time_in_ms (5): 2,410 (+23%)
  • note_history_successful_decrypting_time_in_ms (10): 4,694 (+25%)
  • l2_block_building_time_in_ms (8): 17,327 (+18%)
  • l2_block_building_time_in_ms (32): 69,058 (+19%)
  • l2_block_building_time_in_ms (128): 275,503 (+19%)
  • l2_block_rollup_simulation_time_in_ms (8): 15,767 (+18%)
  • l2_block_rollup_simulation_time_in_ms (32): 62,850 (+19%)
  • l2_block_rollup_simulation_time_in_ms (128): 250,416 (+19%)
  • l2_block_public_tx_process_time_in_ms (8): 1,511 (+16%)
  • l2_block_public_tx_process_time_in_ms (32): 6,060 (+18%)
  • l2_block_public_tx_process_time_in_ms (128): 24,542 (+19%)
  • l2_block_processing_time_in_ms (8): 2,701 (+18%)
  • l2_block_processing_time_in_ms (32): 10,249 (+17%)
  • l2_block_processing_time_in_ms (128): 39,954 (+16%)
  • note_successful_decrypting_time_in_ms (8): 350 (+22%)
  • note_successful_decrypting_time_in_ms (32): 1,020 (+23%)
  • note_successful_decrypting_time_in_ms (128): 3,805 (+26%)
  • note_trial_decrypting_time_in_ms (8): 53.0 (-39%)
  • note_trial_decrypting_time_in_ms (32): 109 (+95%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit f4913623 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,444 179,588 716,132
l1_rollup_calldata_gas 222,876 868,172 3,447,920
l1_rollup_execution_gas 841,963 3,595,280 22,203,289
l2_block_processing_time_in_ms ⚠️ 2,701 (+18%) ⚠️ 10,249 (+17%) ⚠️ 39,954 (+16%)
note_successful_decrypting_time_in_ms ⚠️ 350 (+22%) ⚠️ 1,020 (+23%) ⚠️ 3,805 (+26%)
note_trial_decrypting_time_in_ms ⚠️ 53.0 (-39%) ⚠️ 109 (+95%) 145 (+7%)
l2_block_building_time_in_ms ⚠️ 17,327 (+18%) ⚠️ 69,058 (+19%) ⚠️ 275,503 (+19%)
l2_block_rollup_simulation_time_in_ms ⚠️ 15,767 (+18%) ⚠️ 62,850 (+19%) ⚠️ 250,416 (+19%)
l2_block_public_tx_process_time_in_ms ⚠️ 1,511 (+16%) ⚠️ 6,060 (+18%) ⚠️ 24,542 (+19%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms ⚠️ 28,873 (+16%) ⚠️ 56,671 (+17%)
note_history_successful_decrypting_time_in_ms ⚠️ 2,410 (+23%) ⚠️ 4,694 (+25%)
note_history_trial_decrypting_time_in_ms 126 (+3%) 155 (+7%)
node_database_size_in_bytes 1,632,089 1,098,986
pxe_database_size_in_bytes 27,188 54,187

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 96.3 (+16%) 61,697 18,841
private-kernel-ordering 59.4 (+17%) 24,233 8,089
base-rollup ⚠️ 2,427 (+16%) 656,309 811
root-rollup 108 (+18%) 4,072 1,097
private-kernel-inner 69.9 (+18%) 81,504 18,841
public-kernel-private-input 54.9 (+18%) 41,455 18,841
public-kernel-non-first-iteration 34.4 (+19%) 41,497 18,841
merge-rollup ⚠️ 1.12 (+34%) 2,592 873

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 8,723 27,240

@ludamad ludamad deleted the ax0/master branch August 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants