chore: Disable canary. by charlielye · Pull Request #3244 · AztecProtocol/aztec-packages

charlielye · 2023-11-06T14:49:18Z

In prep to merge #3114
The above would break the canary as bb.js is now required to deployed as it's new used by yarn-project.
This is inevitable as we start proving anyway.
The issue is bb.js is currently deployed independently in GA workflow.
This will need to be changed to deploy as part of CCI workflow.
There are other changes that should be made to "canary" anyway to simplify our build/deploy, so disabling now seem ok.

PhilWindle · 2023-11-06T15:50:24Z

-      - run:
-          name: "yarn-project"
-          command: yarn-project/deploy_ecr.sh
+  # deploy-ecr:


We need this step for our current devnet deployments. These will shortly be made from CCI.

I'm hoping for us to remove all "deployments to ecr".
Now we're fully open source we can just deploy to dockerhub.

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.0</summary> ## [0.14.0](aztec-packages-v0.13.1...aztec-packages-v0.14.0) (2023-11-07) ### ⚠ BREAKING CHANGES * make noir_wasm the default compiler ([#3090](#3090)) * adding all the (note, nonce) pairs in `PXE.addNote` and hiding `PXE.getNoteNonces` ([#3196](#3196)) * API inconsistency fix ([#3190](#3190)) * tree leaf value as `Fr` everywhere in our public API ([#3173](#3173)) ### Features * Add cli command update aztec dependencies ([#3128](#3128)) ([0c05d8b](0c05d8b)) * Add root rollup circuit ([#3217](#3217)) ([fb4f7af](fb4f7af)) * Adding all the (note, nonce) pairs in `PXE.addNote` and hiding `PXE.getNoteNonces` ([#3196](#3196)) ([8c41664](8c41664)) * API inconsistency fix ([#3190](#3190)) ([272eda1](272eda1)) * **docs:** Aztec.nr errors in docs ([#3113](#3113)) ([fb1e80b](fb1e80b)) * **docs:** New getting started flow ([#2957](#2957)) ([f23f868](f23f868)) * Enable pkc in noir ([#3194](#3194)) ([1ef892b](1ef892b)) * Extract types to a types crate ([#3203](#3203)) ([4161be9](4161be9)) * Gperftools ([#3096](#3096)) ([ea2f9a7](ea2f9a7)) * Initial storage slots docs ([#2842](#2842)) ([e8bcd03](e8bcd03)) * Make noir_wasm the default compiler ([#3090](#3090)) ([ca52a3e](ca52a3e)) * Migrate cpp private kernel tests to noir ([#3165](#3165)) ([daee2f9](daee2f9)) * More test info in tx receipt ([#3221](#3221)) ([a7354dc](a7354dc)), closes [#3218](#3218) * Tag artifacts with the compiler version ([#3220](#3220)) ([c7490c5](c7490c5)) * Tree leaf value as `Fr` everywhere in our public API ([#3173](#3173)) ([09464ca](09464ca)) ### Bug Fixes * Attempt to fix spot request hangs. ([#3241](#3241)) ([a062026](a062026)) * Better update steps for dockerized sandbox ([#3204](#3204)) ([3ef0bee](3ef0bee)) * Build cli image before releasing ([#3140](#3140)) ([09c3b75](09c3b75)) * Cleanup gen_inner_proof_files.sh script. ([#3242](#3242)) ([ee57e00](ee57e00)) * Corrects typo in repo readme ([#3236](#3236)) ([0ed8c79](0ed8c79)) * Remove noirup from noir-contract's bootstrap ([#3252](#3252)) ([d10342e](d10342e)) * Remove unused import ([#3200](#3200)) ([520bba4](520bba4)) * Temporary fix for bb prove w/ ram rom blocks ([#3215](#3215)) ([af93a33](af93a33)) * Update noir-contracts path to types ([#3247](#3247)) ([c5fc95d](c5fc95d)) * Wasm-compiler `bin` package type ([#3254](#3254)) ([2d50f11](2d50f11)) * Yarn prepare ([#3251](#3251)) ([d02726f](d02726f)) ### Miscellaneous * Add initial skeleton code for root/merge/mase rollups for Noir ([#3178](#3178)) ([7b0d076](7b0d076)) * Bump noir ([#3197](#3197)) ([aa2042d](aa2042d)) * Clean up and refactor arithmetization ([#3164](#3164)) ([0370b13](0370b13)) * Continuation of note naming update ([#3137](#3137)) ([582150f](582150f)) * Disable canary. ([#3244](#3244)) ([1a56173](1a56173)) * Docs: fix broken link in functions.md ([#3183](#3183)) ([fb53f7a](fb53f7a)) * **docs:** Fix docs build ([#3249](#3249)) ([ec2c0cf](ec2c0cf)) * Fix typo in aztec sandbox ([#3191](#3191)) ([ed144b1](ed144b1)) * More boiler plate code for merge rollup ([#3182](#3182)) ([ffafcef](ffafcef)) * Move flavors ([#3188](#3188)) ([f1ff849](f1ff849)) * Move honk/pcs ([#3187](#3187)) ([3870ff8](3870ff8)) * Move log deriv lookup accum to library ([#3226](#3226)) ([189d1bb](189d1bb)) * Move sumcheck ([#3189](#3189)) ([410cae3](410cae3)) * Move transcripts ([#3176](#3176)) ([7372d19](7372d19)) * Noir circuit tests ([#3229](#3229)) ([dbfb086](dbfb086)) * Private kernel circuits ([#3240](#3240)) ([b7fbe19](b7fbe19)) * Prune 0 values from L2Tx ([#3224](#3224)) ([2de206d](2de206d)) * Refactor e2e to not use @aztec/types ([#3175](#3175)) ([006a07a](006a07a)), closes [#3157](#3157) * Remove extra println in noir protoco circuit ([#3219](#3219)) ([3295fdd](3295fdd)) * Split out relations, PG, Honk variants ([#3238](#3238)) ([8abd39f](8abd39f)) * Update Noir version ([#3082](#3082)) ([59eb6af](59eb6af)) ### Documentation * Fix bad shareable key crypto. better explanations ([#3228](#3228)) ([e4a0c4a](e4a0c4a)) * Fix in nullifier secrets doc ([#3167](#3167)) ([8c70845](8c70845)) * Move Updating.md file, add aztec tag to nargo update instruction ([#3213](#3213)) ([9f71c5d](9f71c5d)) * Update docs ([#3223](#3223)) ([7977064](7977064)) * Update storage doc ([#3212](#3212)) ([d707d4e](d707d4e)) * Updated stale tree docs ([#3166](#3166)) ([3d5c98c](3d5c98c)) </details> <details><summary>barretenberg.js: 0.14.0</summary> ## [0.14.0](barretenberg.js-v0.13.1...barretenberg.js-v0.14.0) (2023-11-07) ### Miscellaneous * **barretenberg.js:** Synchronize aztec-packages versions </details> <details><summary>barretenberg: 0.14.0</summary> ## [0.14.0](barretenberg-v0.13.1...barretenberg-v0.14.0) (2023-11-07) ### Features * Gperftools ([#3096](#3096)) ([ea2f9a7](ea2f9a7)) ### Bug Fixes * Cleanup gen_inner_proof_files.sh script. ([#3242](#3242)) ([ee57e00](ee57e00)) * Temporary fix for bb prove w/ ram rom blocks ([#3215](#3215)) ([af93a33](af93a33)) ### Miscellaneous * Clean up and refactor arithmetization ([#3164](#3164)) ([0370b13](0370b13)) * Move flavors ([#3188](#3188)) ([f1ff849](f1ff849)) * Move honk/pcs ([#3187](#3187)) ([3870ff8](3870ff8)) * Move log deriv lookup accum to library ([#3226](#3226)) ([189d1bb](189d1bb)) * Move sumcheck ([#3189](#3189)) ([410cae3](410cae3)) * Move transcripts ([#3176](#3176)) ([7372d19](7372d19)) * Split out relations, PG, Honk variants ([#3238](#3238)) ([8abd39f](8abd39f)) ### Documentation * Updated stale tree docs ([#3166](#3166)) ([3d5c98c](3d5c98c)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…m in ts via bb.js pedersen call. (#3114) * This was originally going to use our TS pedersen lib to do all pedersen computations, but wasm is 10x faster, so we still want to use wasm. * Introduce `elliptic` version of pedersen as it can be much faster than `@noble/curves` (WARNING: Jest totally messes with benchmarks and can't be trusted for timings with this stuff). Leaving noble version in for now in case want to revisit, but not exported via index. The `elliptic` version is also just there as reference (maybe useful in future). * The pedersen api required being passed a wasm, and that wasm was obtained via async call. This creates a tonne of async function overhead and is generally a bit of a faff. * This adds `foundation/crypto/pedersen/pedersen.wasm.ts` (and defaults to using it via index.ts) that mimics our pure TS pedersen api, but uses the bb.js wasm. * Adds a hand rolled synchronous pedersen bind caller to bb.js (I should probably bring back making bindgen produce the sync api, but also figured might adopt Adams msgpack approach so not worth effort). * `foundation/crypto/pedersen` leverages top-level await to load the wasm as a global, so we can remove a tonne of async await calls. * We cleanup some of the c_binds in barretenberg. * We still use circuits.wasm for a couple of more complex calls ive not tackled yet, e.g. `hashVK`. * We now have dependency on bb.js, pulled in via `portal` yarn thingy. *What does this mean for releases?* (edit: This would probably have broken canary. This PR disabled canary. #3244) * Pulls the bbmalloc WASM_EXPORTS into own header so it doesn't mess with the bindgen util. * Broke some circular import dependencies as I was hitting weird errors. * All pedersen calls now made on `foundation/crypto/pedersen`, got rid of `circuits/barretenberg/crypto/pedersen` wrapper. * Enable colorizing debug output in e2e tests via `DEBUG_COLOR=1`. * Change some `test()` to `it()` (was faffing with other test runner when profiling pedersen). * Timer uses `performance.now` rather than `Date.getTime()` * Introduces `madge` as a tool to detect circular deps. TODO in subsequent PR's. * Move all the hashing functions in `abis.ts` to exist as hash functions on the various types. * Implement hash functions for e.g. vkHash and a couple others that were to complicated for doing right now. * Move the types out of circuits.js into types project. * Ultimately remove need for circuits.js / circuits.wasm?

…m in ts via bb.js pedersen call. (#3114) * This was originally going to use our TS pedersen lib to do all pedersen computations, but wasm is 10x faster, so we still want to use wasm. * Introduce `elliptic` version of pedersen as it can be much faster than `@noble/curves` (WARNING: Jest totally messes with benchmarks and can't be trusted for timings with this stuff). Leaving noble version in for now in case want to revisit, but not exported via index. The `elliptic` version is also just there as reference (maybe useful in future). * The pedersen api required being passed a wasm, and that wasm was obtained via async call. This creates a tonne of async function overhead and is generally a bit of a faff. * This adds `foundation/crypto/pedersen/pedersen.wasm.ts` (and defaults to using it via index.ts) that mimics our pure TS pedersen api, but uses the bb.js wasm. * Adds a hand rolled synchronous pedersen bind caller to bb.js (I should probably bring back making bindgen produce the sync api, but also figured might adopt Adams msgpack approach so not worth effort). * `foundation/crypto/pedersen` leverages top-level await to load the wasm as a global, so we can remove a tonne of async await calls. * We cleanup some of the c_binds in barretenberg. * We still use circuits.wasm for a couple of more complex calls ive not tackled yet, e.g. `hashVK`. * We now have dependency on bb.js, pulled in via `portal` yarn thingy. *What does this mean for releases?* (edit: This would probably have broken canary. This PR disabled canary. AztecProtocol/aztec-packages#3244) * Pulls the bbmalloc WASM_EXPORTS into own header so it doesn't mess with the bindgen util. * Broke some circular import dependencies as I was hitting weird errors. * All pedersen calls now made on `foundation/crypto/pedersen`, got rid of `circuits/barretenberg/crypto/pedersen` wrapper. * Enable colorizing debug output in e2e tests via `DEBUG_COLOR=1`. * Change some `test()` to `it()` (was faffing with other test runner when profiling pedersen). * Timer uses `performance.now` rather than `Date.getTime()` * Introduces `madge` as a tool to detect circular deps. TODO in subsequent PR's. * Move all the hashing functions in `abis.ts` to exist as hash functions on the various types. * Implement hash functions for e.g. vkHash and a couple others that were to complicated for doing right now. * Move the types out of circuits.js into types project. * Ultimately remove need for circuits.js / circuits.wasm?

…m in ts via bb.js pedersen call. (#3114) * This was originally going to use our TS pedersen lib to do all pedersen computations, but wasm is 10x faster, so we still want to use wasm. * Introduce `elliptic` version of pedersen as it can be much faster than `@noble/curves` (WARNING: Jest totally messes with benchmarks and can't be trusted for timings with this stuff). Leaving noble version in for now in case want to revisit, but not exported via index. The `elliptic` version is also just there as reference (maybe useful in future). * The pedersen api required being passed a wasm, and that wasm was obtained via async call. This creates a tonne of async function overhead and is generally a bit of a faff. * This adds `foundation/crypto/pedersen/pedersen.wasm.ts` (and defaults to using it via index.ts) that mimics our pure TS pedersen api, but uses the bb.js wasm. * Adds a hand rolled synchronous pedersen bind caller to bb.js (I should probably bring back making bindgen produce the sync api, but also figured might adopt Adams msgpack approach so not worth effort). * `foundation/crypto/pedersen` leverages top-level await to load the wasm as a global, so we can remove a tonne of async await calls. * We cleanup some of the c_binds in barretenberg. * We still use circuits.wasm for a couple of more complex calls ive not tackled yet, e.g. `hashVK`. * We now have dependency on bb.js, pulled in via `portal` yarn thingy. *What does this mean for releases?* (edit: This would probably have broken canary. This PR disabled canary. AztecProtocol/aztec-packages#3244) * Pulls the bbmalloc WASM_EXPORTS into own header so it doesn't mess with the bindgen util. * Broke some circular import dependencies as I was hitting weird errors. * All pedersen calls now made on `foundation/crypto/pedersen`, got rid of `circuits/barretenberg/crypto/pedersen` wrapper. * Enable colorizing debug output in e2e tests via `DEBUG_COLOR=1`. * Change some `test()` to `it()` (was faffing with other test runner when profiling pedersen). * Timer uses `performance.now` rather than `Date.getTime()` * Introduces `madge` as a tool to detect circular deps. TODO in subsequent PR's. * Move all the hashing functions in `abis.ts` to exist as hash functions on the various types. * Implement hash functions for e.g. vkHash and a couple others that were to complicated for doing right now. * Move the types out of circuits.js into types project. * Ultimately remove need for circuits.js / circuits.wasm?

Disable canary.

578e7a3

charlielye requested review from PhilWindle and spypsy November 6, 2023 14:49

PhilWindle requested changes Nov 6, 2023

View reviewed changes

PhilWindle approved these changes Nov 6, 2023

View reviewed changes

PhilWindle merged commit 1a56173 into master Nov 6, 2023

PhilWindle deleted the cl/disable_canary branch November 6, 2023 17:04

AztecBot mentioned this pull request Nov 6, 2023

chore(master): Release 0.14.0 #3158

Merged

charlielye mentioned this pull request Nov 6, 2023

chore!: Replace computing hashes in circuits wasm, with computing them in ts via bb.js pedersen call. #3114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Disable canary.#3244

chore: Disable canary.#3244
PhilWindle merged 1 commit into
masterfrom
cl/disable_canary

charlielye commented Nov 6, 2023

Uh oh!

PhilWindle Nov 6, 2023

Uh oh!

charlielye Nov 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

charlielye commented Nov 6, 2023

Uh oh!

PhilWindle Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

charlielye Nov 6, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants