Skip to content

test(fixtures): added TS compilation of noir contracts#39

Merged
ludamad merged 5 commits into
masterfrom
arv/ts_compile_noir
Mar 21, 2023
Merged

test(fixtures): added TS compilation of noir contracts#39
ludamad merged 5 commits into
masterfrom
arv/ts_compile_noir

Conversation

@sirasistant

@sirasistant sirasistant commented Mar 13, 2023

Copy link
Copy Markdown
Contributor

Description

Resolves #38
Allows compiling test noir contracts in acir simulator fixtures.
Test don't pass due to a bug in noir wasm tracked here: noir-lang/noir-source-resolver#1

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@LeilaWang

Copy link
Copy Markdown
Contributor

Let's move it to yarn-project/noir-contracts with a pre-generated test_contract.json so that the e2e tests can use it for testing :)

@ludamad ludamad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ludamad ludamad merged commit 3477302 into master Mar 21, 2023
@charlielye charlielye deleted the arv/ts_compile_noir branch March 28, 2023 21:19
ludamad pushed a commit that referenced this pull request Jul 19, 2023
docs: typo in userguide.md
ludamad pushed a commit that referenced this pull request Jul 21, 2023
docs: typo in userguide.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Engineers can programatically compile test contracts that adhere to the Private Circuit Public Inputs ABI

3 participants