refactor: keep track of blocks emitting/cancelling messages#4028
Merged
Conversation
alexghr
changed the title
Collaborator
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
Tree insertion statsThe duration to insert a fixed batch of leaves into each tree type.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
Transaction processing duration by data writes.
|
PhilWindle
requested changes
Jan 16, 2024
PhilWindle
left a comment
PhilWindle
left a comment
Collaborator
There was a problem hiding this comment.
Just a couple of minor nits.
| } | ||
|
|
||
| getL1BlockNumber(): Promise<bigint> { | ||
| getL1BlockNumber() { |
Collaborator
There was a problem hiding this comment.
Could you comment this please?
PhilWindle
approved these changes
Jan 16, 2024
PhilWindle
pushed a commit
that referenced
this pull request
Jan 19, 2024
This PR refactors the archiver store to use `@aztec/kv-store` instead of lmdb directly. It is stacked on top of #4028. The diff looks massive but all it does is split the archiver store into individual pieces to better separate them conceptually (blocks, logs, contracts, messages) and replace direct uses of lmdb with the data structures from kv-store.
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this pull request
Feb 28, 2024
…tocol#4028) This PR refactors the archiver to keep track of which L1 block last emitted messages or cancelled messages (similar to how it discovers L2 blocks) in order to make the synch process more efficient.
michaelelliot
pushed a commit
to Swoir/noir_rs
that referenced
this pull request
Feb 28, 2024
This PR refactors the archiver store to use `@aztec/kv-store` instead of lmdb directly. It is stacked on top of AztecProtocol#4028. The diff looks massive but all it does is split the archiver store into individual pieces to better separate them conceptually (blocks, logs, contracts, messages) and replace direct uses of lmdb with the data structures from kv-store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the archiver to keep track of which L1 block last emitted messages or cancelled messages (similar to how it discovers L2 blocks) in order to make the synch process more efficient.