Skip to content

fix: upload_benchmarks_to_s3.sh missing exit #4046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Maddiaa0 merged 2 commits into from
Jan 18, 2024
Merged

fix: upload_benchmarks_to_s3.sh missing exit #4046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79dc4e8
fix: upload_benchmarks_to_s3.sh missing exit
ludamad Jan 16, 2024
c57d66f
Merge branch 'master' into ad/fix/uploads3bench
ludamad Jan 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion barretenberg/cpp/scripts/ci/upload_benchmarks_to_s3.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ elif [ -n "${PULL_REQUEST:-}" ]; then
TARGET_FOLDER="barretenberg-bench-v1/pulls/${PULL_REQUEST##*/}"
else
echo Skipping upload since no target folder was defined
exit
fi
echo "Uploading to s3://$BUCKET_NAME/$TARGET_FOLDER"
aws s3 cp extracted-repo/src/barretenberg/cpp/build/ultra_honk_rounds_bench.json "s3://$BUCKET_NAME/$TARGET_FOLDER/ultra_honk_rounds_bench.json"
aws s3 cp extracted-repo/src/barretenberg/cpp/build/ultra_honk_rounds_bench.json "s3://$BUCKET_NAME/$TARGET_FOLDER/ultra_honk_rounds_bench.json"