fix: Various manual fixes/tweaks in preparation for clang-tidy PR#415
Merged
Conversation
Collaborator
|
LGTM (so far) |
Contributor
Author
|
Thanks @ludamad. Just flagged it as ready after pushing the actual The purpose of this intermediate/separate PR is that you/others can merge just this patch into your branches so you can then run clang-tidy successfully to relieve some pains when trying to merge the larger refactor which is coming next. |
6 tasks
ludamad
approved these changes
Apr 29, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
Co-authored-by: cheethas <addaboy@gmail.com>
This was referenced Jul 25, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
Co-authored-by: cheethas <addaboy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Blocks #393
The purpose of this intermediate/separate PR is that individuals can merge just this patch into their branches so they can then run clang-tidy successfully to relieve some pains when trying to merge the larger refactor which is coming next.
Checklist: