Skip to content

Preperation for L2 -> L1#421

Merged
LHerskind merged 2 commits into
masterfrom
lh/l2_l1_preperation
May 2, 2023
Merged

Preperation for L2 -> L1#421
LHerskind merged 2 commits into
masterfrom
lh/l2_l1_preperation

Conversation

@LHerskind

@LHerskind LHerskind commented May 2, 2023

Copy link
Copy Markdown
Contributor

Description

Part of #381, performing some much needed cleanup before handling logic as seen in #382

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@LHerskind LHerskind marked this pull request as ready for review May 2, 2023 12:55
@ludamad

ludamad commented May 2, 2023

Copy link
Copy Markdown
Collaborator

LGTM

@LHerskind LHerskind merged commit 78e6f6d into master May 2, 2023
@LHerskind LHerskind deleted the lh/l2_l1_preperation branch May 2, 2023 13:12
iakovenkos added a commit that referenced this pull request Mar 30, 2026
@iakovenkos
fix #421, and a confusing comment in Gemini prover
e108577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ludamad ludamad ludamad approved these changes

@Maddiaa0 Maddiaa0 Awaiting requested review from Maddiaa0

+1 more reviewer

@rahul-kothari rahul-kothari rahul-kothari approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LHerskind @ludamad @rahul-kothari