feat(compiler): adds Aztec noir compiler#438
Merged
Merged
Conversation
sirasistant
changed the title
Contributor
Author
|
|
sirasistant
changed the title
spalladino
approved these changes
May 5, 2023
spalladino
left a comment
spalladino
left a comment
Contributor
There was a problem hiding this comment.
LGTM! I left a bunch of comments, none of them a dealbreaker.
Currently, this noir compiler uses noir master branch. It's not compatible yet with the test contracts for Aztec that are in the noir-contracts package, that need to be built following its README.md instructions.
What would it take to have this compiler use a different branch..?
Comment on lines
+100
to
+103
| return compile({ | ||
| contracts: true, | ||
| optional_dependencies_set: Object.keys(dependenciesMap), // eslint-disable-line camelcase | ||
| }); |
Contributor
There was a problem hiding this comment.
Hold on, is the noirResolver a global object, and not an instance that we pass onto the compiler? Can we change that in noir? Global objects are always a pain.
Contributor
Author
There was a problem hiding this comment.
I'm afraid it is ): I'll check if it's possible to do in a different way on noir side, because it interacts with autogenerated code from wasm-bindgen
LeilaWang
approved these changes
May 5, 2023
ludamad
pushed a commit
that referenced
this pull request
Jul 14, 2023
…ting circuit (#438) * Add way to make verifiers data valid by replacing zeroes with valid public keys and signatures Co-authored-by: Zachary James Williamson <zac-williamson@users.noreply.github.com> * Update cpp/src/barretenberg/dsl/acir_format/ecdsa_secp256k1.test.cpp * replace templates with concrete methods * add comment * PR review * add comments * change to use boolean flag, so dummy_ecdsa method lives in ecdsa * ad true as default --------- Co-authored-by: Zachary James Williamson <zac-williamson@users.noreply.github.com>
This was referenced Jul 25, 2023
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
…ting circuit (#438) * Add way to make verifiers data valid by replacing zeroes with valid public keys and signatures Co-authored-by: Zachary James Williamson <zac-williamson@users.noreply.github.com> * Update cpp/src/barretenberg/dsl/acir_format/ecdsa_secp256k1.test.cpp * replace templates with concrete methods * add comment * PR review * add comments * change to use boolean flag, so dummy_ecdsa method lives in ecdsa * ad true as default --------- Co-authored-by: Zachary James Williamson <zac-williamson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #392
Added a noir compiler CLI tool that allows to compile noir contracts using master
noir_wasmand outputs aztec formatted ABIs.Currently, this noir compiler uses noir master branch. It's not compatible yet with the test contracts for Aztec that are in the
noir-contractspackage, that need to be built following its README.md instructions.Checklist: