Skip to content

chore(avm-circuit): tests use OpCode enum's instead of hardcoded values #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbanks12 merged 2 commits into from
Feb 12, 2024
Merged

chore(avm-circuit): tests use OpCode enum's instead of hardcoded values #4554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2c02ea
chore(avm-circuit): tests use OpCode enum's instead of hardcoded values
Feb 12, 2024
3d191f6
fix to_hex to work without std::format
Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions barretenberg/cpp/src/barretenberg/vm/avm_trace/AvmMini_opcode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#include "AvmMini_opcode.hpp"

#include <cstdint>
#include <iomanip>
#include <sstream>

namespace avm_trace {

Expand Down Expand Up @@ -150,4 +153,12 @@ bool Bytecode::has_in_tag(OpCode const op_code)
}
}

std::string to_hex(OpCode opcode)
{
std::ostringstream stream;
// pad with 0s to fill exactly 2 hex characters
stream << std::setfill('0') << std::setw(2) << std::hex << (static_cast<uint8_t>(opcode) & 0xFF);
return stream.str();
}

} // namespace avm_trace
3 changes: 3 additions & 0 deletions barretenberg/cpp/src/barretenberg/vm/avm_trace/AvmMini_opcode.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <cstddef>
#include <cstdint>
#include <string>
#include <unordered_map>

namespace avm_trace {
Expand Down Expand Up @@ -102,4 +103,6 @@ class Bytecode {
static const std::unordered_map<OpCode, size_t> OPERANDS_NUM;
};

std::string to_hex(OpCode opcode);

} // namespace avm_trace
Loading