Skip to content

Revert "feat: native fee payment"#4668

Closed
alexghr wants to merge 1 commit into
masterfrom
revert-4543-feat/gas-token
Closed

Revert "feat: native fee payment"#4668
alexghr wants to merge 1 commit into
masterfrom
revert-4543-feat/gas-token

Conversation

@alexghr

@alexghr alexghr commented Feb 19, 2024

Copy link
Copy Markdown
Contributor

Reverts #4543

@AztecBot

Copy link
Copy Markdown
Collaborator

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit c04d72fd and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 46,020 181,668 724,260
l1_rollup_calldata_gas 227,112 888,768 3,535,620
l1_rollup_execution_gas 321,298 1,008,216 3,757,021
l2_block_processing_time_in_ms 1,192 (-2%) 4,473 (-9%) 17,699 (-9%)
note_successful_decrypting_time_in_ms 219 (+1%) 606 (-7%) 2,135 (-11%)
note_trial_decrypting_time_in_ms 30.9 (+8%) 39.8 (-55%) 173 (-14%)
l2_block_building_time_in_ms 18,960 75,026 (-1%) 300,017 (-6%)
l2_block_rollup_simulation_time_in_ms 13,820 54,554 (-2%) 218,892 (-6%)
l2_block_public_tx_process_time_in_ms 5,110 20,224 80,868 (-6%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,551 (-6%) 28,859 (-1%)
note_history_successful_decrypting_time_in_ms 1,382 (-2%) 2,705 (-2%)
note_history_trial_decrypting_time_in_ms 176 (+3%) 215 (-4%)
node_database_size_in_bytes 17,277,008 33,239,120
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 330 (-2%) 44,664 25,409
private-kernel-ordering 211 (-2%) 43,729 14,627
base-rollup 1,488 (-2%) 128,080 933
root-rollup 83.3 (-2%) 4,192 825
private-kernel-inner 431 (-2%) 71,051 25,409
public-kernel-app-logic 260 (-2%) 32,126 25,251
merge-rollup 7.80 (-4%) 2,712 933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.3 (-3%) 10.6 (-12%) 12.7 (-3%) 17.6 (+2%) 23.0 (-6%) 63.8 (-25%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.593 (-3%) 0.591 (-12%) 0.538 (-2%) 0.541 (+1%) 0.481 (-6%) 0.440 (-25%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 75.1 (-8%) 47.5 (-3%) 239 (-3%) 467 (+1%) 898 (-5%) 3,539 (-7%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.464 (-7%) 0.487 (-3%) 0.436 (-3%) 0.437 (+1%) 0.428 (-4%) 0.426 (-6%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 104 (-7%) 56.6 (-4%) 350 690 1,371 (-12%) 5,414 (-8%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.492 (-7%) 0.495 (-4%) 0.475 0.473 0.474 (-11%) 0.469 (-7%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.9 (-4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.577 (-4%) N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,388 36,001

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 571 (-2%) 1,484 (-3%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.0325 (+5%) 626 (-2%)

@just-mitch just-mitch closed this Feb 19, 2024
@just-mitch

Copy link
Copy Markdown
Collaborator

Closed because we merged #4670

@alexghr alexghr deleted the revert-4543-feat/gas-token branch February 19, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants