Skip to content

chore(boxes): adding frontend test to vanilla-js box#4770

Merged
signorecello merged 13 commits into
masterfrom
zpedro/boxes_ftest
Mar 4, 2024
Merged

chore(boxes): adding frontend test to vanilla-js box#4770
signorecello merged 13 commits into
masterfrom
zpedro/boxes_ftest

Conversation

@signorecello

@signorecello signorecello commented Feb 26, 2024

Copy link
Copy Markdown
Contributor

Please read contributing guidelines and remove this line.

signorecello commented Feb 26, 2024

Copy link
Copy Markdown
Contributor Author

@signorecello signorecello changed the title wip chore(boxes): adding frontend test Feb 26, 2024
@signorecello signorecello marked this pull request as ready for review February 26, 2024 15:50
@AztecBot

AztecBot commented Feb 26, 2024

Copy link
Copy Markdown
Collaborator

Benchmark results

Metrics with a significant change:

  • note_trial_decrypting_time_in_ms (8): 110 (+634%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 8619c084 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,700 18,884 36,452
l1_rollup_calldata_gas 66,120 238,664 469,076
l1_rollup_execution_gas 194,068 499,970 908,334
l2_block_processing_time_in_ms 1,200 (-3%) 4,550 (-1%) 9,014 (-1%)
note_successful_decrypting_time_in_ms 199 (-2%) 548 (-3%) 1,002 (-4%)
note_trial_decrypting_time_in_ms ⚠️ 110 (+634%) 72.3 (-23%) 39.1 (-40%)
l2_block_building_time_in_ms 15,975 (-2%) 63,375 (-1%) 130,307 (+2%)
l2_block_rollup_simulation_time_in_ms 12,121 (-2%) 48,088 (-1%) 99,775 (+2%)
l2_block_public_tx_process_time_in_ms 3,824 (-2%) 15,199 30,368

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,287 (-3%) 27,404 (-1%)
note_history_successful_decrypting_time_in_ms 1,260 (+1%) 2,423
note_history_trial_decrypting_time_in_ms 95.8 (-1%) 139 (-10%)
node_database_size_in_bytes 18,788,432 35,491,920
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 249 44,736 28,001
private-kernel-ordering 178 (-1%) 52,625 14,627
base-rollup 1,300 177,932 933
root-rollup 71.0 4,192 825
private-kernel-inner 315 73,715 28,001
public-kernel-app-logic 193 (+1%) 32,254 25,379
merge-rollup 7.21 (+24%) 2,712 933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.98 10.2 (-7%) 12.5 16.7 22.1 (-13%) 35.6 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 79.0 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.578 (+1%) 0.568 (-6%) 0.532 0.515 (+1%) 0.462 (-12%) 0.443 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 46.1 73.1 (-1%) 231 (-2%) 445 874 1,728
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 96.0 159 543 1,055 2,079 4,127
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.472 0.450 0.422 (-2%) 0.416 0.416 0.413
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 54.2 109 337 (-3%) 666 1,316 2,614 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 104 207 691 1,363 2,707 5,395
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.481 0.489 0.455 (-2%) 0.458 0.456 0.453
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A 61.3 (-1%) N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A 109 N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A 0.535 N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts
tx_size_in_bytes 19,179

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 2,653 (+1%) 1,359
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.0352 (+4%) 472

@signorecello signorecello force-pushed the zpedro/boxes_ftest branch 8 times, most recently from 9cf9d9c to 06b3ca6 Compare February 27, 2024 15:58
@socket-security

socket-security Bot commented Feb 27, 2024

Copy link
Copy Markdown

No dependency changes detected. Learn more about Socket for GitHub ↗︎

👍 No dependency changes detected in pull request

@signorecello signorecello changed the title chore(boxes): adding frontend test wip Feb 28, 2024
@signorecello signorecello changed the title wip chore(docs): adding frontend test to vanilla-js box Feb 28, 2024
@signorecello signorecello requested review from a team, charlielye and rahul-kothari February 28, 2024 11:03
Comment thread boxes/Dockerfile Outdated
Comment thread boxes/docker-compose.yml Outdated
@signorecello signorecello changed the title chore(docs): adding frontend test to vanilla-js box chore(boxes): adding frontend test to vanilla-js box Mar 4, 2024

signorecello commented Mar 4, 2024

Copy link
Copy Markdown
Contributor Author

Merge activity

@signorecello signorecello merged commit cd1ca2e into master Mar 4, 2024
@signorecello signorecello deleted the zpedro/boxes_ftest branch March 4, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants