feat: initial integration avm prover

[IlyasRidhuan]

Basic shim to integrate avm simulator with the avm witgen/prover.

Currently uses the bb binary and supports proving(including passing in calldata) and verifying (although both are currently WIP in the avm prover).

Built on top of #4877

[AztecBot]

Benchmark results

Metrics with a significant change:

• node_history_sync_time_in_ms (5): 14,065 (-17%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d483e678 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	64 txs
l1_rollup_calldata_size_in_bytes	5,700	18,884	36,452
l1_rollup_calldata_gas	66,432	239,540	470,168
l1_rollup_execution_gas	673,895	980,361	1,388,942
l2_block_processing_time_in_ms	1,325 (+1%)	4,720	8,920
note_successful_decrypting_time_in_ms	141 (-2%)	472 (-4%)	940 (-5%)
note_trial_decrypting_time_in_ms	44.9 (-6%)	97.7 (-6%)	71.1 (-38%)
l2_block_building_time_in_ms	12,063	47,301 (-1%)	94,553 (-1%)
l2_block_rollup_simulation_time_in_ms	7,348	28,961 (-1%)	58,514
l2_block_public_tx_process_time_in_ms	4,682	18,277	35,921 (-3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	⚠️ 14,065 (-17%)	28,072 (+6%)
note_history_successful_decrypting_time_in_ms	1,284 (+2%)	2,541 (+6%)
note_history_trial_decrypting_time_in_ms	116 (+13%)	218 (+33%)
node_database_size_in_bytes	18,882,640 (+1%)	35,573,840
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	251	44,736	28,001
private-kernel-ordering	194 (-1%)	52,625	14,627
base-rollup	664	177,932	997
root-rollup	69.5 (-3%)	4,320	825
private-kernel-inner	318	73,715	28,001
public-kernel-app-logic	163 (-1%)	34,920	27,972
public-kernel-tail	81.4 (-1%)	34,507	27,972
merge-rollup	8.64 (-4%)	2,840	997

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	64 leaves	128 leaves	512 leaves	1024 leaves	2048 leaves	4096 leaves
batch_insert_into_append_only_tree_16_depth_ms	9.81 (-5%)	10.4 (+3%)	12.2	16.1 (-4%)	22.0	35.3 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	79.0	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.569 (-5%)	0.580 (+3%)	0.517	0.498 (-5%)	0.460	0.440 (+1%)	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	45.8 (-6%)	71.6 (+1%)	229	447 (-3%)	865	1,685 (-2%)
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	96.0	159	543	1,055	2,079	4,127
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.469 (-6%)	0.442 (+1%)	0.418	0.418 (-3%)	0.411	0.403 (-2%)
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	54.9 (-3%)	106	337	666 (-4%)	1,304	2,559 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	104	207	691	1,363	2,707	5,395
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.488 (-4%)	0.478	0.458	0.457 (-4%)	0.452	0.444 (-2%)
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	N/A	61.4 (-4%)	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	N/A	109	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	N/A	0.535 (-4%)	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts
tx_size_in_bytes	19,650

Transaction processing duration by data writes.

Metric	0 new note hashes	1 new note hashes
tx_pxe_processing_time_ms	2,763 (+1%)	1,378

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	7.37 (-2%)	572

[dbanks12]

Nice work! Left some comments. Let's wait for @Maddiaa0's review on this.

[Maddiaa0]

Do you think we should we create this from an opcode array then call serialize; rather than hard coding the string?

[jeanmon]

I would rather use HEX encoding. The goal is not to save space but make it readable for the developer.

[fcarreiro]

Do you think we should we create this from an opcode array then call serialize; rather than hard coding the string?

He might be trying to avoid introducing a dependency to the instructions and the simulator. I think that's right because at this level of abstraction that shouldn't matter. However, having the hardcoded bytecode is also a pain if we ever change anything.

I'd suggest just removing this test and relying on the one(s) using "AvmTestContractArtifact."

[IlyasRidhuan]

Yep i was hesitant to introduce the dependency on the simulator here.

The plan would be to use the one from the AvmTestContractArtifact when the AVM supports the MOV opcode(it's skipped below this test until then).

Once that is supported I'll happily remove this test.

In terms of the encoding, the bytecode stored in the transpiled noir contract is base64 encoded, so im keeping it consistent here with what it would receive from retrieving the contract artifact

[jeanmon]

LGTM. Please have a look at my comments.

[jeanmon]

I would rather use HEX encoding. The goal is not to save space but make it readable for the developer.