Skip to content

feat: Sync from noir#5234

Merged
sirasistant merged 5 commits into
masterfrom
sync-noir
Mar 15, 2024
Merged

feat: Sync from noir#5234
sirasistant merged 5 commits into
masterfrom
sync-noir

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: separate tests for execution failures from compilation failures (noir-lang/noir#4559)
feat: remove curly braces with fmt (noir-lang/noir#4529)
fix: Make nargo the default binary for cargo run (noir-lang/noir#4554)
fix: Evaluate operators in globals in types (noir-lang/noir#4537)
chore: Add more Hash impls to stdlib (noir-lang/noir#4470)
END_COMMIT_OVERRIDE

…tion failures (noir-lang/noir#4559)

feat: remove curly braces with fmt  (noir-lang/noir#4529)
fix: Make `nargo` the default binary for cargo run (noir-lang/noir#4554)
fix: Evaluate operators in globals in types (noir-lang/noir#4537)
chore: Add more `Hash` impls to stdlib (noir-lang/noir#4470)
@AztecBot

AztecBot commented Mar 15, 2024

Copy link
Copy Markdown
Collaborator Author

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 9a733487 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 5,668 18,820 36,356
l1_rollup_calldata_gas 66,448 239,176 (+1%) 469,820
l1_rollup_execution_gas 667,129 954,086 1,337,177
l2_block_processing_time_in_ms 1,269 (-2%) 4,772 (+8%) 9,022 (+2%)
note_successful_decrypting_time_in_ms 148 (+6%) 580 (+3%) 995 (+1%)
note_trial_decrypting_time_in_ms 55.6 (+23%) 95.1 (+21%) 123 (+4%)
l2_block_building_time_in_ms 18,551 69,318 138,406 (+2%)
l2_block_rollup_simulation_time_in_ms 8,184 (-2%) 28,522 (-2%) 57,212 (+2%)
l2_block_public_tx_process_time_in_ms 10,346 (+1%) 40,742 (+1%) 81,095 (+3%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 14,395 (-1%) 27,338 (+1%)
note_history_successful_decrypting_time_in_ms 1,289 (+4%) 2,574 (+5%)
note_history_trial_decrypting_time_in_ms 111 (+24%) 118 (-24%)
node_database_size_in_bytes 19,071,056 35,696,720
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 282 44,370 27,700
private-kernel-ordering 219 (+1%) 52,324 14,326
base-parity 1,824 (-3%) 128 311
base-rollup 723 177,083 925
root-parity 1,641 (+6%) 1,244 311
root-rollup 69.3 (+1%) 4,487 789
private-kernel-inner 642 (+1%) 73,229 27,700
public-kernel-app-logic 456 (+2%) 35,262 28,215
public-kernel-tail 179 (+2%) 40,926 28,215
merge-rollup 8.43 (+2%) 2,696 925

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 9.98 15.9 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.582 0.492 (-1%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 46.0 71.7 229 (-3%) 444 865 (+2%) 1,728 (+2%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.472 0.443 0.420 (-2%) 0.416 0.411 (+1%) 0.413 (+2%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 53.5 106 336 660 1,298 (+1%) 2,616 (+2%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 104 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.477 0.480 (+1%) 0.457 0.455 0.452 (+1%) 0.453 (+2%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 60.9
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.534

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes
tx_size_in_bytes 22,014

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes
tx_pxe_processing_time_ms 3,334 (+2%) 1,781 (+2%)
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 13.0 (-5%) 1,274 (+2%)

@github-actions

github-actions Bot commented Mar 15, 2024

Copy link
Copy Markdown
Contributor

Changes to circuit sizes

Generated at commit: c24856b9469c1b4f0ffd68758b2dd9a10d8e6abc, compared to commit: 9a7334877f5e109c6d2695a9119414c0643f480e

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_teardown -1,638 ✅ -5.58% -1,638 ✅ -0.90%
private_kernel_tail -49,026 ✅ -11.60% -49,411 ✅ -5.56%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
public_kernel_teardown 27,717 (-1,638) -5.58% 180,408 (-1,638) -0.90%
private_kernel_tail 373,467 (-49,026) -11.60% 839,573 (-49,411) -5.56%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants