Skip to content

chore: Add quick explanatory comment to outbox suggested by @benesjan #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sklppy88 merged 2 commits into from
Mar 15, 2024
Merged

chore: Add quick explanatory comment to outbox suggested by @benesjan #5247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
993d37c
initial
Mar 15, 2024
303258e
Slither
Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions l1-contracts/slither_output.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ src/core/messagebridge/NewInbox.sol#L41


- [ ] ID-13
[NewOutbox.constructor(address)._rollup](src/core/messagebridge/NewOutbox.sol#L30) lacks a zero-check on :
- [ROLLUP_CONTRACT = _rollup](src/core/messagebridge/NewOutbox.sol#L31)
[NewOutbox.constructor(address)._rollup](src/core/messagebridge/NewOutbox.sol#L31) lacks a zero-check on :
- [ROLLUP_CONTRACT = _rollup](src/core/messagebridge/NewOutbox.sol#L32)

src/core/messagebridge/NewOutbox.sol#L30
src/core/messagebridge/NewOutbox.sol#L31


## reentrancy-events
Expand Down Expand Up @@ -245,10 +245,10 @@ src/core/messagebridge/Inbox.sol#L21-L231


- [ ] ID-25
The following public functions could be turned into external in [NewOutbox](src/core/messagebridge/NewOutbox.sol#L18-L131) contract:
[NewOutbox.constructor(address)](src/core/messagebridge/NewOutbox.sol#L30-L32)
The following public functions could be turned into external in [NewOutbox](src/core/messagebridge/NewOutbox.sol#L18-L132) contract:
[NewOutbox.constructor(address)](src/core/messagebridge/NewOutbox.sol#L31-L33)

src/core/messagebridge/NewOutbox.sol#L18-L131
src/core/messagebridge/NewOutbox.sol#L18-L132


- [ ] ID-26
Expand Down Expand Up @@ -359,9 +359,9 @@ src/core/Rollup.sol#L41
Impact: Optimization
Confidence: High
- [ ] ID-40
In a function [NewOutbox.insert(uint256,bytes32,uint256)](src/core/messagebridge/NewOutbox.sol#L43-L63) variable [NewOutbox.roots](src/core/messagebridge/NewOutbox.sol#L28) is read multiple times
In a function [NewOutbox.insert(uint256,bytes32,uint256)](src/core/messagebridge/NewOutbox.sol#L44-L64) variable [NewOutbox.roots](src/core/messagebridge/NewOutbox.sol#L29) is read multiple times

src/core/messagebridge/NewOutbox.sol#L43-L63
src/core/messagebridge/NewOutbox.sol#L44-L64


- [ ] ID-41
Expand Down
1 change: 1 addition & 0 deletions l1-contracts/src/core/messagebridge/NewOutbox.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ contract NewOutbox is INewOutbox {
using Hash for DataStructures.L2ToL1Msg;

struct RootData {
// This is the outhash specified by header.globalvariables.outHash of any given block.
bytes32 root;
uint256 height;
mapping(uint256 => bool) nullified;
Expand Down