Skip to content

feat: dont build tests in non assert wasm build#532

Merged
dbanks12 merged 1 commit into
masterfrom
md/wasm-build
May 9, 2023
Merged

feat: dont build tests in non assert wasm build#532
dbanks12 merged 1 commit into
masterfrom
md/wasm-build

Conversation

@Maddiaa0

@Maddiaa0 Maddiaa0 commented May 9, 2023

Copy link
Copy Markdown
Member

Description

Cuts about a minute and a half off the build time

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Maddiaa0 Maddiaa0 requested a review from dbanks12 May 9, 2023 18:11

@dbanks12 dbanks12 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@dbanks12

dbanks12 commented May 9, 2023

Copy link
Copy Markdown
Contributor

All of the CI has passed, but for some reason Github is showing them as still running. Going to merge.

@dbanks12 dbanks12 merged commit 32b0cd2 into master May 9, 2023
@dbanks12 dbanks12 deleted the md/wasm-build branch May 9, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants