feat(acir_gen): Fold attribute at compile-time and initial non inlined ACIR#5341
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves noir-lang/noir#4428 but not fully. Need ACVM execution work still.
This does the initial codegen work for having multiple ACIR functions.
It does a few things:
InlineTypethat is now part ofRuntimeType::Acir. We do not care aboutRuntimeType::Brilligas we do not inline any of those calls.Circuitfunctions inside of aProgram. Previously we were just returning the main function signature. This is needed to accurately set up theprivate_parametersandpublic_parametersfields in a circuit.Callopcode from feat!: Acir call opcode #4773