feat!: Brillig typed memory#5395
Merged
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brillig had implicitely typed memory, where the memory typing was supossedly respected by the compiler (brillig_gen) but was never checked in runtime. Instead, in runtime the values were truncated to the appropiate bit size when used. This hid some bugs in typing that the compiler was outputting and that would have made the AVM crash.
Memory typing bugs found and fixed:
This PR aligns brillig more with the AVM by having typed memory actually checked in runtime, and removing the truncations that arithmetic.rs was doing.