feat(simulator): Fetch return values at circuit execution#5642
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were deserializing a
Programtwice in the simulator. Once to execute the circuit and again to fetch the return witness. Every call toexecuteCircuitWithBlackBoxSolveris followed by a call togetReturnWitnessin the simulator. We should just pass the return witness right away as to not cross the WASM boundary a second time and as to avoid a second deserialization.I settled on a new ACVM method rather than using abi decoding as the return witnesses are stripped from the ABI. We can have a method that returns both the fully solved witness and the return witness based upon the circuit. This allows us to both avoid storing duplicate return witness information and an unnecessary deserialization.