Skip to content

feat: Sync from noir#5794

Merged
TomAFrench merged 10 commits into
masterfrom
sync-noir
Apr 17, 2024
Merged

feat: Sync from noir#5794
TomAFrench merged 10 commits into
masterfrom
sync-noir

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: fix alerts on rust msrv (noir-lang/noir#4817)
chore(ci): fix alerts on msrv issues (noir-lang/noir#4816)
chore: run clippy (noir-lang/noir#4810)
chore: optimize poseidon2 implementation (noir-lang/noir#4807)
fix: catch panics from EC point creation (e.g. the point is at infinity) (noir-lang/noir#4790)
feat: Sync from aztec-packages (noir-lang/noir#4792)
feat: lalrpop lexer prototype (noir-lang/noir#4656)
feat(nargo): Handle call stacks for multiple Acir calls (noir-lang/noir#4711)
fix: proper field inversion for bigints (noir-lang/noir#4802)
feat: add NARGO_FOREIGN_CALL_TIMEOUT environment variable (noir-lang/noir#4780)
chore(debugger): Docs (noir-lang/noir#4145)
feat: narrow ABI encoding errors down to target problem argument/field (noir-lang/noir#4798)
chore: Rename 'global' to 'function' in the monomorphization pass (noir-lang/noir#4774)
chore: Add Hir -> Ast conversion (noir-lang/noir#4788)
fix: Fix panic when returning a zeroed unit value (noir-lang/noir#4797)
END_COMMIT_OVERRIDE

AztecBot and others added 6 commits April 16, 2024 19:45
chore(ci): fix alerts on msrv issues (noir-lang/noir#4816)
chore: run clippy (noir-lang/noir#4810)
chore: optimize poseidon2 implementation (noir-lang/noir#4807)
fix: catch panics from EC point creation (e.g. the point is at infinity) (noir-lang/noir#4790)
feat: Sync from aztec-packages (noir-lang/noir#4792)
feat: lalrpop lexer prototype (noir-lang/noir#4656)
feat(nargo): Handle call stacks for multiple Acir calls (noir-lang/noir#4711)
fix: proper field inversion for bigints (noir-lang/noir#4802)
feat: add `NARGO_FOREIGN_CALL_TIMEOUT` environment variable (noir-lang/noir#4780)
chore(debugger): Docs (noir-lang/noir#4145)
feat: narrow ABI encoding errors down to target problem argument/field (noir-lang/noir#4798)
chore: Rename 'global' to 'function' in the monomorphization pass (noir-lang/noir#4774)
chore: Add Hir -> Ast conversion (noir-lang/noir#4788)
fix: Fix panic when returning a zeroed unit value (noir-lang/noir#4797)
@AztecBot

AztecBot commented Apr 16, 2024

Copy link
Copy Markdown
Collaborator Author

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,844 6,832 6,844
l1_rollup_execution_gas 587,325 587,313 587,325
l2_block_processing_time_in_ms 1,514 (+2%) 5,302 (-2%) 10,283 (-3%)
note_successful_decrypting_time_in_ms 190 (-21%) 591 (+1%) 881 (-3%)
note_trial_decrypting_time_in_ms 91.7 (+68%) 97.9 (+7%) 97.6 (-20%)
l2_block_building_time_in_ms 13,316 52,255 104,563 (+1%)
l2_block_rollup_simulation_time_in_ms 13,088 51,424 102,925 (+1%)
l2_block_public_tx_process_time_in_ms 5,711 (+1%) 22,303 (-2%) 44,631 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,777 (+5%) 29,635 (-2%)
note_history_successful_decrypting_time_in_ms 1,239 2,344 (+6%)
note_history_trial_decrypting_time_in_ms 61.3 (+20%) 76.9 (-37%)
node_database_size_in_bytes 18,722,896 34,975,824
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 154 (+3%) 44,725 26,424
private-kernel-inner 164 (+2%) 72,200 26,424
private-kernel-ordering 113 (+3%) 51,090 39,297
base-parity 41.8 (+4%) 128 311
root-parity 7.14 1,244 311
base-rollup 16,427 (+2%) 110,820 957
root-rollup 47.4 4,551 821
public-kernel-app-logic 91.4 (+2%) 48,175 40,933
public-kernel-tail 126 (+2%) 60,044 7,385
merge-rollup 7.58 (+1%) 2,760 957
public-kernel-teardown 85.0 (-1%) 48,175 40,933
public-kernel-setup 84.1 (-1%) 48,175 40,933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.0 18.5 (+4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.640 0.573 (+4%) N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.6 80.8 (-1%) 259 (-2%) 516 (+3%) 979 (-2%) 1,943 (-3%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.530 0.498 (-1%) 0.472 (-2%) 0.482 (+2%) 0.465 (-3%) 0.465 (-3%) N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 61.1 (+2%) 119 (-2%) 373 (-4%) 767 (+4%) 1,456 (-4%) 2,902 (-4%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.540 (+1%) 0.539 (-2%) 0.509 (-5%) 0.527 (+3%) 0.505 (-4%) 0.505 (-4%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 68.6 (+2%)
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.599 (+1%)

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 41,029 528,895

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 905 1,161 1,377

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,198 815 (+3%) 3,441
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 507 (+2%) 331 902 (+1%) 417 1,491 491 (+1%)

@TomAFrench

Copy link
Copy Markdown
Member

Looks like somethings not been updated to handle the new debug info format in contracts?

inflate(Buffer.from(functionArtifact.debugSymbols, 'base64'), { to: 'string', raw: true }),
);
return { debugSymbols, files: contractArtifact.fileMap };
// TODO(https://github.com/AztecProtocol/aztec-packages/issues/5813)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirasistant Pinging you for awareness. Not sure if there is anyone else who would be better to ping as well. You can look into that issue for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants