Skip to content

Use cci build context. Remove unneeded options from eip712.#58

Merged
charlielye merged 1 commit into
masterfrom
cl/cci_build_context
Mar 17, 2023
Merged

Use cci build context. Remove unneeded options from eip712.#58
charlielye merged 1 commit into
masterfrom
cl/cci_build_context

Conversation

@charlielye

Copy link
Copy Markdown
Contributor

Description

We've moved common environment variables to a cii build context that can be reused across repos.
This also removes a some unused options from the eip712 code in ethereum.js

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@charlielye charlielye merged commit 5513004 into master Mar 17, 2023
@charlielye charlielye deleted the cl/cci_build_context branch March 28, 2023 21:18
ludamad pushed a commit that referenced this pull request Jul 14, 2023
ludamad pushed a commit that referenced this pull request Jul 19, 2023
ludamad pushed a commit that referenced this pull request Jul 21, 2023
codygunton added a commit that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant