Skip to content

feat: Sync from noir#5955

Merged
TomAFrench merged 12 commits into
masterfrom
sync-noir
Apr 23, 2024
Merged

feat: Sync from noir#5955
TomAFrench merged 12 commits into
masterfrom
sync-noir

Conversation

@AztecBot

Copy link
Copy Markdown
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: Delete unused brillig methods (noir-lang/noir#4887)
feat(acir_gen): Brillig stdlib (noir-lang/noir#4848)
END_COMMIT_OVERRIDE

"lint": "NODE_NO_WARNINGS=1 eslint . --ext .ts --ignore-path ./.eslintignore --max-warnings 0"
},
"dependencies": {
"@aztec/bb.js": "0.35.1",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed in this sync #5935 we didn't switch back to a portal. I have brought the portal back as to not stump someone making breaking changes

@TomAFrench TomAFrench merged commit 8f73f18 into master Apr 23, 2024
@TomAFrench TomAFrench deleted the sync-noir branch April 23, 2024 15:57
@AztecBot

Copy link
Copy Markdown
Collaborator Author

Benchmark results

Metrics with a significant change:

  • note_successful_decrypting_time_in_ms (32): 345 (-31%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 64 txs
l1_rollup_calldata_size_in_bytes 772 772 772
l1_rollup_calldata_gas 6,844 6,844 6,820
l1_rollup_execution_gas 587,325 587,325 587,301
l2_block_processing_time_in_ms 1,482 (-3%) 5,404 (+3%) 10,387 (-1%)
note_successful_decrypting_time_in_ms 195 (+15%) ⚠️ 345 (-31%) 737 (+4%)
note_trial_decrypting_time_in_ms 86.1 (+35%) 39.0 (-61%) 49.2 (-57%)
l2_block_building_time_in_ms 18,864 73,650 147,548 (+1%)
l2_block_rollup_simulation_time_in_ms 18,637 72,884 146,067 (+1%)
l2_block_public_tx_process_time_in_ms 8,598 (+1%) 33,351 67,619 (+2%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 16,322 (+1%) 29,254 (-4%)
note_history_successful_decrypting_time_in_ms 961 (+1%) 1,742 (-5%)
note_history_trial_decrypting_time_in_ms 79.0 (+15%) 108 (-18%)
node_database_size_in_bytes 19,107,920 35,876,944
pxe_database_size_in_bytes 29,859 59,414

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 156 47,763 31,978
private-kernel-inner 177 80,794 31,978
private-kernel-ordering 136 (-1%) 57,732 50,043
base-parity 76.5 (+4%) 128 265
root-parity 123 (+2%) 1,244 265
base-rollup 12,240 (-1%) 110,926 957
root-rollup 49.6 (-1%) 4,551 821
public-kernel-app-logic 1,659 62,017 52,067
public-kernel-tail 4,209 168,566 7,491
merge-rollup 3,212 (-1%) 2,760 957
public-kernel-teardown 118 (+5%) 62,017 52,067
public-kernel-setup 118 (-1%) 62,017 52,067

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 512 leaves 1024 leaves 2048 leaves 4096 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 11.0 17.8 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.6 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.637 0.550 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 51.7 (+1%) 80.4 260 500 (-1%) 987 (+1%) 1,952 (+1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 96.0 159 543 1,055 2,079 4,127 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.529 (+1%) 0.496 0.474 0.467 (-1%) 0.469 (+1%) 0.467 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 60.7 119 375 735 (-1%) 1,465 2,943 (+1%) N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 105 207 691 1,363 2,707 5,395 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.536 0.537 0.511 0.506 (-1%) 0.506 0.512 (+1%) N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A N/A 67.7
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A N/A 109
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A N/A 0.590

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 51,411 543,524

Transaction size based on fee payment method

Metric native fee payment method fpc_public fee payment method fpc_private fee payment method
tx_with_fee_size_in_bytes 897 1,145 1,345

Transaction processing duration by data writes.

Metric 0 new note hashes 1 new note hashes 2 new note hashes
tx_pxe_processing_time_ms 1,241 (-1%) 863 (-1%) 3,457 (-1%)
Metric 1 public data writes 2 public data writes 3 public data writes 4 public data writes 5 public data writes 8 public data writes
tx_sequencer_processing_time_ms 838 756 (-1%) 1,344 (-1%) 898 (-1%) 2,061 (-2%) 1,088 (-1%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants