feat: Reproducible ClientIVC proofs#6227
Merged
Merged
Conversation
Tested with: Vanilla, client ivc Full test.
This was referenced May 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of my work on #6218, I integrated deterministic randomness in order to have reproducible Goblin IVC proofs. This PR isolate those changes. In also includes some changes I made in order to verify that the same work gives us reproducible Client IVC proofs. Along the way I recognize that serialization of Client IVC proofs was broken (translation evaluations were not included). I fixed this as well.