chore: fixing linter issues + cleanup#674
Merged
Merged
Conversation
6 tasks
Maddiaa0
reviewed
May 23, 2023
Maddiaa0
left a comment
Maddiaa0
left a comment
Member
There was a problem hiding this comment.
lgtm, lets add to the dockerfile.
Maddiaa0
approved these changes
May 23, 2023
LHerskind
force-pushed
the
lh/593-fixing-linter-issues
branch
from
c632e82 to
7e124fd
Compare
Maddiaa0
reviewed
May 23, 2023
LHerskind
force-pushed
the
lh/593-fixing-linter-issues
branch
from
b23e2e8 to
066bbd7
Compare
Maddiaa0
approved these changes
May 23, 2023
nishatkoti
added a commit
that referenced
this pull request
Feb 27, 2026
Cleanup and minor changes in the polynomial module.
Changes:
- Delete unused methods in `univariate_coefficient_basis.hpp`
- `is_zero`
- `random_element`
- `to_buffer`
- `serialize_from_buffer`
- `size`
- `get_random`
- Delete unused methods in `polynomial.hpp/cpp`
- `clear()`
- `right_shifted()`
- `debug_hash()`
- `compute_barycentric_evaluation()`
- `in_place_operation_viable`
- overload of evaluate `evaluate(const Fr& z, size_t target_size)`
- Delete unused methods in `polynomial_arithmetic.hpp/cpp`
- `compute_multiplicative_subgroup`
- `compute_barycentric_evaluation `
- `fft`, `coset_fft`, unused overloads of `fft_inner_parallel` and
`ifft`
- Delete unused `compute_generator_table` and `four_inverse` in
`evaluation_domain.hpp`
- Fixed `_allocate_aligned_memory` call to pass element count (`n_l`)
instead of byte size.
- Add new tests in `barycentric.test.cpp` covering the `stdlib` runtime
path
- Deduplicate compile-time and runtime `BarycentricData` logic via a
shared base class (resolves TODO
[#674](AztecProtocol/barretenberg#674))
johnathan79717
pushed a commit
that referenced
this pull request
Mar 4, 2026
Cleanup and minor changes in the polynomial module.
Changes:
- Delete unused methods in `univariate_coefficient_basis.hpp`
- `is_zero`
- `random_element`
- `to_buffer`
- `serialize_from_buffer`
- `size`
- `get_random`
- Delete unused methods in `polynomial.hpp/cpp`
- `clear()`
- `right_shifted()`
- `debug_hash()`
- `compute_barycentric_evaluation()`
- `in_place_operation_viable`
- overload of evaluate `evaluate(const Fr& z, size_t target_size)`
- Delete unused methods in `polynomial_arithmetic.hpp/cpp`
- `compute_multiplicative_subgroup`
- `compute_barycentric_evaluation `
- `fft`, `coset_fft`, unused overloads of `fft_inner_parallel` and
`ifft`
- Delete unused `compute_generator_table` and `four_inverse` in
`evaluation_domain.hpp`
- Fixed `_allocate_aligned_memory` call to pass element count (`n_l`)
instead of byte size.
- Add new tests in `barycentric.test.cpp` covering the `stdlib` runtime
path
- Deduplicate compile-time and runtime `BarycentricData` logic via a
shared base class (resolves TODO
[#674](AztecProtocol/barretenberg#674))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
interfaces->libraries->contractscomprehensive-interfaceruleChecklist: