Skip to content

fix: adding encrypted logs basic test#6920

Closed
sklppy88 wants to merge 1 commit into
masterfrom
ek/fix/6530/adding-encrypted-logs-basic-test
Closed

fix: adding encrypted logs basic test#6920
sklppy88 wants to merge 1 commit into
masterfrom
ek/fix/6530/adding-encrypted-logs-basic-test

Conversation

@sklppy88

@sklppy88 sklppy88 commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Please read contributing guidelines and remove this line.

sklppy88 commented Jun 5, 2024

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

@sklppy88 sklppy88 changed the title Initial fix: adding encrypted logs basic test Jun 5, 2024
@AztecBot

AztecBot commented Jun 5, 2024

Copy link
Copy Markdown
Collaborator

Benchmark results

Metrics with a significant change:

  • app_circuit_witness_generation_time_in_ms (SchnorrAccount:constructor): 1,463 (-20%)
  • protocol_circuit_witness_generation_time_in_ms (private-kernel-inner): 1,012 (-16%)
  • pxe_database_size_in_bytes (3): 9,242 (+19%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,727 1,555 (+1%) 717 (+2%) 753 780 (+2%)
proof_construction_time_sha256_30_ms 12,173 (+3%) 3,233 (+3%) 1,464 (+4%) 1,450 (+2%) 1,493 (+2%)
proof_construction_time_sha256_100_ms 45,962 (+3%) 12,495 (+4%) 6,119 (+8%) 5,975 (+7%) 5,791 (+6%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 59.0 (+2%) 87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms 1,515 417 (+1%) 201 (+1%) 222 (-1%) 267
proof_construction_time_poseidon_hash_100_ms 5,758 1,577 739 (+1%) 792 (+4%) 807 (+2%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412
l1_rollup_calldata_gas 9,464 9,456
l1_rollup_execution_gas 608,000 607,992
l2_block_processing_time_in_ms 699 (+1%) 1,322 (+3%)
l2_block_building_time_in_ms 22,424 46,063 (+1%)
l2_block_rollup_simulation_time_in_ms 22,304 45,712 (+1%)
l2_block_public_tx_process_time_in_ms 19,152 42,281 (+1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 5,937 (+1%) 8,799 (+4%)
node_database_size_in_bytes 9,457,744 (-1%) 12,726,352
pxe_database_size_in_bytes ⚠️ 9,242 (+19%) 15,127

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 136 501 (-1%) 11,950 (-3%) 20,634 64,614 89,536 2,731 524,288
private-kernel-inner 407 ⚠️ 1,012 (-16%) 45,603 92,326 64,614 89,536 2,731 2,097,152
private-kernel-tail 371 1,874 (-5%) 38,719 (-9%) 96,545 68,261 11,648 297 2,097,152
base-parity 6.55 (-4%) 1,742 (-2%) 2,502 (-7%) 128 64.0 2,208 2.00 131,072
root-parity 50.0 (-4%) 51.1 (-2%) 33,970 27,100 64.0 2,720 18.0 2,097,152
base-rollup 5,961 (-1%) 2,309 (-2%) 69,261 (-7%) 119,738 756 3,648 47.0 4,194,304
root-rollup 112 62.9 (+1%) 19,745 (-1%) 25,309 620 3,456 41.0 1,048,576
public-kernel-app-logic 571 (+1%) 3,490 (-3%) 39,286 (-1%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-tail 1,147 (+1%) 22,626 (+1%) 155,628 403,238 7,646 11,648 297 8,388,608
private-kernel-reset-small 588 2,127 42,651 (-2%) 120,737 64,614 89,536 2,731 2,097,152
public-kernel-setup 666 (-1%) 2,670 (-1%) 37,431 (-1%) 108,073 86,550 116,768 3,582 2,097,152
public-kernel-teardown 568 3,510 (-2%) 38,993 (-1%) 108,073 86,550 116,768 3,582 2,097,152
merge-rollup 29.8 (-7%) N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 7,210 47,806 (-3%) N/A N/A 116,768 3,582 2,097,152

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 465 (-1%) N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 42.3 (+1%) N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,796 (-11%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 ⚠️ 1,463 (-20%) N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,827 16,768 50,589 (+1%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,651 (-5%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 1,135 (+1%) 16,768 10,036 (-2%) 524,288 457
Token:transfer 1,376 9,944 5,427 16,768 48,160 2,097,152 457
Benchmarking:create_note 1,344 9,944 1,395 N/A N/A N/A N/A
SchnorrAccount:spend_private_authwit 1,280 9,944 76.9 N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,918 N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,793 N/A N/A N/A N/A

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves 32 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.5 17.0 (-2%) N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.7 N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.609 0.523 (-2%) N/A N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 49.2 (-2%) 76.1 134 (+1%) 247 476 (+1%) N/A
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 288 543 1,055 N/A
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.502 (-2%) 0.470 0.461 (+1%) 0.449 (+1%) 0.443 N/A
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 59.1 (-2%) 113 (+1%) 185 (+1%) 362 (+3%) 626 N/A
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 107 208 355 686 1,263 N/A
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.510 (-2%) 0.504 0.490 (+1%) 0.496 (+4%) 0.468 N/A
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A N/A N/A N/A N/A 59.8
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A N/A N/A N/A N/A 101
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A N/A N/A N/A N/A 0.558

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 79,470 665,267

Transaction size based on fee payment method

| Metric | |
| - | |

@sklppy88 sklppy88 force-pushed the ek/fix/6530/adding-encrypted-logs-basic-test branch from daa2770 to ec5cd7b Compare June 7, 2024 09:39
@sklppy88

Copy link
Copy Markdown
Contributor Author

Closed in favor of #6921

@sklppy88 sklppy88 closed this Jun 10, 2024
@sklppy88 sklppy88 deleted the ek/fix/6530/adding-encrypted-logs-basic-test branch February 12, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants