Skip to content

sequencer integration with L1 -> L2#696

Merged
Maddiaa0 merged 2 commits into
masterfrom
rk/sequencerl1Tol2
May 26, 2023
Merged

sequencer integration with L1 -> L2#696
Maddiaa0 merged 2 commits into
masterfrom
rk/sequencerl1Tol2

Conversation

@rahul-kothari

Copy link
Copy Markdown
Contributor

Description

Fixes #529 (builds on #520 and #691)

  • Archiver returns a list of pending message keys sorted by fees
  • Archiver can also return a confirmed message given a key (useful for noir oracle calls)
  • To implement the noir oracle call, aztec node has appropriate getter functions
  • oracle call now fetches the appropriate message and the message index in the L1_TO_L2_MESSAGE_TREE
  • Sequencer now calls the archiver to fetch pending messages to consume them in a l2 block (appropriate L1ToL2MessageSource interface was implemented)

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@rahul-kothari rahul-kothari requested a review from Maddiaa0 May 26, 2023 09:40

@Maddiaa0 Maddiaa0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good!

Comment thread yarn-project/sequencer-client/src/sequencer/sequencer.ts Outdated
Comment thread yarn-project/aztec-rpc/src/simulator_oracle/index.ts Outdated
Comment thread yarn-project/aztec-node/src/aztec-node/server.ts Outdated
@rahul-kothari rahul-kothari requested a review from Maddiaa0 May 26, 2023 12:22

@Maddiaa0 Maddiaa0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Maddiaa0 Maddiaa0 merged commit 7d33c03 into master May 26, 2023
@Maddiaa0 Maddiaa0 deleted the rk/sequencerl1Tol2 branch May 26, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sequencer pulls L1 -> L2 messages from archiver

2 participants