fix: fields fromstring not working

[sklppy88]

Please read contributing guidelines and remove this line.

[sklppy88]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: fields fromstring not working #7366 👈
• fix: fields fromstring not working as intended #7365
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:mint_public): 84.1 (-77%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 90.7 (+44%)
• avm_simulation_time_ms (Token:transfer_public): 27.9 (-31%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric	1 threads	4 threads	16 threads	32 threads	64 threads
proof_construction_time_sha256_ms	5,748	1,549 (+1%)	705	753 (-1%)	769
proof_construction_time_sha256_30_ms	11,808 (+1%)	3,164 (+1%)	1,406	1,445 (+1%)	1,478 (+1%)
proof_construction_time_sha256_100_ms	44,004 (+1%)	11,840 (+1%)	6,187 (-6%)	5,364 (-1%)	5,345 (-1%)
proof_construction_time_poseidon_hash_ms	78.0	34.0	35.0 (+3%)	59.0 (+2%)	87.0
proof_construction_time_poseidon_hash_30_ms	1,527 (+1%)	418	199	238 (+6%)	266 (-1%)
proof_construction_time_poseidon_hash_100_ms	5,662 (+1%)	1,527 (+1%)	680 (+1%)	738 (+3%)	747

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	4 txs	8 txs	16 txs
l1_rollup_calldata_size_in_bytes	1,412	1,412	1,412
l1_rollup_calldata_gas	9,464	9,460	9,476
l1_rollup_execution_gas	613,492	613,639	613,806
l2_block_processing_time_in_ms	748 (-1%)	1,418	2,683 (-2%)
l2_block_building_time_in_ms	12,951	25,463	50,343
l2_block_rollup_simulation_time_in_ms	12,951	25,462	50,343
l2_block_public_tx_process_time_in_ms	10,904	23,239	48,109

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric	3 blocks	5 blocks
node_history_sync_time_in_ms	7,010	10,008
node_database_size_in_bytes	12,423,248	16,191,568
pxe_database_size_in_bytes	16,254	26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit	simulation_time_in_ms	witness_generation_time_in_ms	proving_time_in_ms	input_size_in_bytes	output_size_in_bytes	proof_size_in_bytes	num_public_inputs	size_in_gates
private-kernel-init	107 (-4%)	396	14,578	20,002	55,022	74,208	2,252	524,288
private-kernel-inner	222	706	30,427 (+6%)	82,134	55,022	74,208	2,252	1,048,576
private-kernel-tail	1,056 (-1%)	2,440 (-3%)	57,214 (+7%)	62,409	62,089	14,944	400	2,097,152
base-parity	6.29	858 (-3%)	2,670 (+1%)	160	96.0	2,240	3.00	131,072
root-parity	69.8	80.6 (+8%)	41,138	27,868	96.0	2,752	19.0	2,097,152
base-rollup	4,146	4,935	94,821 (+2%)	172,028	632	3,552	44.0	4,194,304
root-rollup	127	88.2 (-1%)	22,885 (-4%)	25,053	652	3,488	42.0	1,048,576
public-kernel-setup	189 (-1%)	2,406	42,605 (-4%)	103,911	80,310	106,944	3,275	2,097,152
public-kernel-app-logic	145 (-1%)	3,374 (+1%)	44,030 (+6%)	103,911	80,310	106,944	3,275	2,097,152
public-kernel-tail	892	24,360 (+1%)	186,400 (+4%)	400,808	10,046	14,944	400	8,388,608
private-kernel-reset-small	291	1,181 (+4%)	25,996	79,273	55,022	74,208	2,252	1,048,576
public-kernel-teardown	134	3,313 (-1%)	42,745 (-6%)	103,911	80,310	106,944	3,275	2,097,152
merge-rollup	41.9 (+4%)	N/A	N/A	16,094	632	N/A	N/A	N/A
private-kernel-tail-to-public	N/A	9,013 (-2%)	64,369 (+5%)	N/A	N/A	106,944	3,275	2,097,152

Stats on running time collected for app circuits

Function	input_size_in_bytes	output_size_in_bytes	witness_generation_time_in_ms	proof_size_in_bytes	proving_time_in_ms	size_in_gates	num_public_inputs
ContractClassRegisterer:register	1,312	9,344	396 (+1%)	N/A	N/A	N/A	N/A
ContractInstanceDeployer:deploy	1,376	9,344	24.8 (+1%)	N/A	N/A	N/A	N/A
MultiCallEntrypoint:entrypoint	1,888	9,344	647 (+1%)	N/A	N/A	N/A	N/A
GasToken:deploy	1,344	9,344	562 (+1%)	N/A	N/A	N/A	N/A
SchnorrAccount:constructor	1,280	9,344	480	N/A	N/A	N/A	N/A
SchnorrAccount:entrypoint	2,272	9,344	818 (-1%)	15,840	4,762 (+1%)	131,072	428
Token:privately_mint_private_note	1,248	9,344	547	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_public	1,312	9,344	101 (-4%)	15,840	1,707	65,536	428
Token:transfer	1,280	9,344	1,629 (-1%)	15,840	11,899 (+2%)	524,288	428
AuthRegistry:set_authorized (avm)	19,222	N/A	N/A	91,232	1,401 (+1%)	N/A	N/A
FPC:prepare_fee (avm)	26,664	N/A	N/A	91,296	3,210 (+9%)	N/A	N/A
Token:transfer_public (avm)	42,914	N/A	N/A	91,296	3,969	N/A	N/A
AuthRegistry:consume (avm)	33,100	N/A	N/A	91,232	3,032 (+9%)	N/A	N/A
FPC:pay_refund (avm)	36,829	N/A	N/A	91,264	23,818 (-1%)	N/A	N/A
Benchmarking:create_note	1,312	9,344	465 (-1%)	N/A	N/A	N/A	N/A
SchnorrAccount:verify_private_authwit	1,248	9,344	41.4	N/A	N/A	N/A	N/A
Token:unshield	1,344	9,344	1,338 (-1%)	N/A	N/A	N/A	N/A
FPC:fee_entrypoint_private	1,344	9,344	1,745 (+1%)	N/A	N/A	N/A	N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function	time_ms	bytecode_size_in_bytes
GasToken:_increase_public_balance	80.3	13,790
GasToken:set_portal	12.5 (-18%)	3,339
Token:constructor	106 (+4%)	23,692
FPC:constructor	75.3 (+3%)	13,592
GasToken:mint_public	64.3 (+2%)	10,158
Token:mint_public	⚠️ 84.1 (-77%)	19,034
Token:assert_minter_and_mint	⚠️ 90.7 (+44%)	12,925
AuthRegistry:set_authorized	34.3	7,812
FPC:prepare_fee	112 (+9%)	15,062
Token:transfer_public	⚠️ 27.9 (-31%)	31,218
FPC:pay_refund	123 (-2%)	25,260
Benchmarking:increment_balance	1,317 (-1%)	15,267
Token:_increase_public_balance	15.9 (+6%)	15,006
FPC:pay_refund_with_shielded_rebate	168 (+4%)	26,347

Public DB Access

Time to access various public DBs.

Function	time_ms
get-nullifier-index	0.157 (+1%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	16 leaves	64 leaves	128 leaves	256 leaves	512 leaves	1024 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.4	16.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.8	31.7	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.600	0.514	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	47.9 (-1%)	76.1 (+1%)	131	246	469
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	95.9	159	287	543	1,055
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	0.489 (-1%)	0.468 (+1%)	0.449	0.445	0.438
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	59.4	111	183 (+1%)	356 (+1%)	691
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	109	207	355	691	1,363
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	0.502	0.500	0.484	0.480	0.474
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	72.8	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	133	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	0.518	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric	0 registered classes	1 registered classes
tx_size_in_bytes	74,082	667,868

Transaction size based on fee payment method

| Metric | |
| - | |

[rahul-kothari]

fixes #7334

[rahul-kothari]

shouldnt this also be lowercase a-f?
I think somewhere in the monorepo we have a function with a good regex?

[sklppy88]

The i flag makes it case insensitive, so lowercase a-f is included. I actually don't see anything anywhere that is in aztec.js, which means maybe we should expose some of this to use elsewhere ? I'll make an issue for this to be included in another pr.