Skip to content

feat: add unconstrained context to key getters#7486

Closed
sklppy88 wants to merge 1 commit into
ek/feat/7326/refactor-shared-mutable-to-include-gettersfrom
ek/feat/7326/adding-unconstrained-context-to-key-getters
Closed

feat: add unconstrained context to key getters#7486
sklppy88 wants to merge 1 commit into
ek/feat/7326/refactor-shared-mutable-to-include-gettersfrom
ek/feat/7326/adding-unconstrained-context-to-key-getters

Conversation

@sklppy88

Copy link
Copy Markdown
Contributor

Please read contributing guidelines and remove this line.

sklppy88 commented Jul 15, 2024

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

@sklppy88 sklppy88 changed the title init feat: add unconstrained context to key getters Jul 15, 2024
@github-actions

Copy link
Copy Markdown
Contributor

Changes to circuit sizes

Generated at commit: 26824c8cf4675af87ab46b44c060e5c53868d9cf, compared to commit: 4efbe51a7e0b322990640d367d8a1c33bab08c4c

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_empty_simulated 0 ➖ 0.00% +31 ❌ +7.97%
private_kernel_tail_simulated 0 ➖ 0.00% +31 ❌ +7.97%
public_kernel_tail_simulated 0 ➖ 0.00% +31 ❌ +7.97%
rollup_base +1,769 ❌ +0.52% +75,084 ❌ +2.00%
private_kernel_tail_to_public_simulated 0 ➖ 0.00% +16 ❌ +0.48%
public_kernel_app_logic_simulated 0 ➖ 0.00% +16 ❌ +0.48%
public_kernel_setup_simulated 0 ➖ 0.00% +16 ❌ +0.48%
public_kernel_teardown_simulated 0 ➖ 0.00% +16 ❌ +0.48%
private_kernel_empty +31 ❌ +1.74% +62 ❌ +0.01%
public_kernel_tail +367 ❌ +0.04% -17,564 ✅ -0.38%
public_kernel_teardown -226 ✅ -0.09% -26,997 ✅ -1.64%
public_kernel_setup -342 ✅ -0.19% -27,113 ✅ -1.71%
public_kernel_app_logic -226 ✅ -0.09% -27,093 ✅ -4.61%
private_kernel_tail_to_public -486 ✅ -0.78% -53,930 ✅ -10.86%
private_kernel_tail -1,560 ✅ -7.45% -73,962 ✅ -12.11%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
private_kernel_empty_simulated 1 (0) 0.00% 420 (+31) +7.97%
private_kernel_tail_simulated 1 (0) 0.00% 420 (+31) +7.97%
public_kernel_tail_simulated 1 (0) 0.00% 420 (+31) +7.97%
rollup_base 341,542 (+1,769) +0.52% 3,836,142 (+75,084) +2.00%
private_kernel_tail_to_public_simulated 1 (0) 0.00% 3,344 (+16) +0.48%
public_kernel_app_logic_simulated 1 (0) 0.00% 3,344 (+16) +0.48%
public_kernel_setup_simulated 1 (0) 0.00% 3,344 (+16) +0.48%
public_kernel_teardown_simulated 1 (0) 0.00% 3,344 (+16) +0.48%
private_kernel_empty 1,811 (+31) +1.74% 1,041,821 (+62) +0.01%
public_kernel_tail 965,693 (+367) +0.04% 4,645,487 (-17,564) -0.38%
public_kernel_teardown 241,730 (-226) -0.09% 1,618,002 (-26,997) -1.64%
public_kernel_setup 183,195 (-342) -0.19% 1,554,056 (-27,113) -1.71%
public_kernel_app_logic 240,368 (-226) -0.09% 560,162 (-27,093) -4.61%
private_kernel_tail_to_public 61,801 (-486) -0.78% 442,572 (-53,930) -10.86%
private_kernel_tail 19,368 (-1,560) -7.45% 536,962 (-73,962) -12.11%

@sklppy88 sklppy88 force-pushed the ek/feat/7326/refactor-shared-mutable-to-include-getters branch from 42518ef to 6898030 Compare July 15, 2024 21:01
@sklppy88 sklppy88 force-pushed the ek/feat/7326/adding-unconstrained-context-to-key-getters branch from e5294f0 to ffabfe7 Compare July 15, 2024 21:01
@sklppy88 sklppy88 force-pushed the ek/feat/7326/refactor-shared-mutable-to-include-getters branch from 6898030 to c391ca7 Compare July 15, 2024 21:14
@sklppy88 sklppy88 force-pushed the ek/feat/7326/adding-unconstrained-context-to-key-getters branch from ffabfe7 to 6aee6c3 Compare July 15, 2024 21:14
@sklppy88

sklppy88 commented Aug 9, 2024

Copy link
Copy Markdown
Contributor Author

Closed as going a different direction for key registry.

@sklppy88 sklppy88 closed this Aug 9, 2024
@sklppy88 sklppy88 deleted the ek/feat/7326/adding-unconstrained-context-to-key-getters branch February 12, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant