feat: new proving broker implementation#8609
Conversation
spalladino
left a comment
There was a problem hiding this comment.
Looking good! Most of my comments are around having a different prior mental model for the broker and how it interacts with the backend. I had assumed the broker would keep all metadata needed in memory, and use a backend to persist it and reload in the event of a crash, and another backend for storing and transmitting payloads. Does that make sense?
| export type ProofAndVerificationKey<P> = { | ||
| proof: P; | ||
| verificationKey: VerificationKeyData; | ||
| }; |
There was a problem hiding this comment.
I think we independently introduced the same new types :-P
50f3c40 to
6ad6365
Compare
6ad6365 to
7a79a98
Compare
ae000c2 to
3597330
Compare
This makes sense! Initially I only thought about the inputs needing to be stored separately, but you're right it makes sense to store inputs and outputs to/from the proving process. I the next PR I'll change the |
a13235d to
fc6a757
Compare
fc6a757 to
818ea3b
Compare
This PR adds
ProvingBrokerwhich implements a new interface for distributing proving jobs to workers as specified in #8495