Skip to content

chore(avm): smaller skippable test #8664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fcarreiro merged 1 commit into from
Sep 20, 2024
Merged

chore(avm): smaller skippable test #8664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions barretenberg/cpp/src/barretenberg/vm/avm/tests/fuzz_skippable.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,9 @@ using namespace bb::Avm_vm;
TEST(AvmSkippableTests, shouldSkipCorrectly)
{
using FF = AvmFlavor::FF;
constexpr size_t TRACE_SIZE = 1 << 15;
constexpr size_t TRACE_SIZE = 300;

std::vector<AvmFullRow<FF>> trace(TRACE_SIZE);
std::cerr << "Generating trace of size " << TRACE_SIZE << "..." << std::endl;
// This is the most time consuming part of this test!
// In particular, the generation of random fields.
bb::parallel_for(trace.size(), [&](size_t i) {
Expand All @@ -39,13 +38,11 @@ TEST(AvmSkippableTests, shouldSkipCorrectly)
// Set the conditions for skippable to return true.
row.poseidon2_sel_poseidon_perm = 0;
});
std::cerr << "Done generating trace..." << std::endl;

// We build the polynomials needed to run "sumcheck".
AvmCircuitBuilder cb;
cb.set_trace(std::move(trace));
auto polys = cb.compute_polynomials();
std::cerr << "Done computing polynomials..." << std::endl;

// For each skippable relation we will check:
// 1. That Relation::skippable returns true (i.e., we correctly set the conditions)
Expand Down Expand Up @@ -75,7 +72,7 @@ TEST(AvmSkippableTests, shouldSkipCorrectly)
if (result[j] != 0) {
EXPECT_EQ(result[j], 0)
<< "Relation " << Relation::NAME << " subrelation " << j << " was expected to be zero.";
GTEST_SKIP();
GTEST_FAIL();
}
}
}
Expand Down